Skip to content

Commit 8c33d50

Browse files
committed
point to date formatting options on (x|y|z) axes
1 parent ae2feeb commit 8c33d50

File tree

4 files changed

+20
-10
lines changed

4 files changed

+20
-10
lines changed

src/plots/cartesian/layout_attributes.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@ var dash = require('../../components/drawing/attributes').dash;
66
var extendFlat = require('../../lib/extend').extendFlat;
77
var templatedArray = require('../../plot_api/plot_template').templatedArray;
88

9-
var FORMAT_LINK = require('../../constants/docs').FORMAT_LINK;
10-
var DATE_FORMAT_LINK = require('../../constants/docs').DATE_FORMAT_LINK;
9+
var docs = require('../../constants/docs');
10+
var FORMAT_LINK = docs.FORMAT_LINK;
11+
var DATE_FORMAT_LINK = docs.DATE_FORMAT_LINK;
12+
1113
var ONEDAY = require('../../constants/numerical').ONEDAY;
1214
var constants = require('./constants');
1315
var HOUR = constants.HOUR_PATTERN;

src/plots/hoverformat_attributes.js

+10-4
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
11
'use strict';
22

3-
var FORMAT_LINK = require('../constants/docs').FORMAT_LINK;
3+
var docs = require('../constants/docs')
4+
var FORMAT_LINK = docs.FORMAT_LINK;
5+
var DATE_FORMAT_LINK = docs.DATE_FORMAT_LINK;
46

5-
module.exports = function axisHoverFormat(x, mockedAxis) {
7+
module.exports = function axisHoverFormat(x, noDates) {
68
return {
79
valType: 'string',
810
dflt: '',
911
editType: 'none',
1012
description: [
1113
'Sets the hover text formatting rule for `' + x + '`',
1214
' using d3 formatting mini-languages which are very similar to those in Python.',
13-
'See: ' + FORMAT_LINK,
15+
'See: ' + FORMAT_LINK + (
16+
noDates ?
17+
'' :
18+
' And for dates see: ' + DATE_FORMAT_LINK
19+
),
1420
'By default the values are formatted using ' + (
15-
mockedAxis ?
21+
noDates ?
1622
'generic number format' :
1723
('`' + x + 'axis.hoverformat`')
1824
) + '.',

src/plots/template_attributes.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
'use strict';
22

3-
var FORMAT_LINK = require('../constants/docs').FORMAT_LINK;
4-
var DATE_FORMAT_LINK = require('../constants/docs').DATE_FORMAT_LINK;
3+
var docs = require('../constants/docs');
4+
var FORMAT_LINK = docs.FORMAT_LINK;
5+
var DATE_FORMAT_LINK = docs.DATE_FORMAT_LINK;
56

67
var templateFormatStringDescription = [
78
'Variables are inserted using %{variable}, for example "y: %{y}".',

src/traces/carpet/axis_attributes.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ var colorAttrs = require('../../components/color/attributes');
55
var axesAttrs = require('../../plots/cartesian/layout_attributes');
66
var overrideAll = require('../../plot_api/edit_types').overrideAll;
77

8-
var FORMAT_LINK = require('../../constants/docs').FORMAT_LINK;
9-
var DATE_FORMAT_LINK = require('../../constants/docs').TIME_FORMAT_LINK;
8+
var docs = require('../../constants/docs');
9+
var FORMAT_LINK = docs.FORMAT_LINK;
10+
var DATE_FORMAT_LINK = docs.DATE_FORMAT_LINK;
1011

1112
module.exports = {
1213
color: {

0 commit comments

Comments
 (0)