Skip to content

Commit 89e2437

Browse files
committed
refactor splom base plot
1 parent 73fc99e commit 89e2437

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/traces/splom/base_plot.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -128,36 +128,36 @@ function makeGridData(gd) {
128128
var ya = sp.yaxis;
129129
var xVals = xa._gridVals;
130130
var yVals = ya._gridVals;
131-
var xoffset = xa._offset;
132-
var xlength = xa._length;
133-
var ylength = ya._length;
131+
var xOffset = xa._offset;
132+
var xLength = xa._length;
133+
var yLength = ya._length;
134134

135135
// ya.l2p assumes top-to-bottom coordinate system (a la SVG),
136136
// we need to compute bottom-to-top offsets and slopes:
137-
var yoffset = (gs.b + ya.domain[0] * gs.h);
137+
var yOffset = gs.b + ya.domain[0] * gs.h;
138138
var ym = -ya._m;
139139
var yb = -ym * ya.r2l(ya.range[0], ya.calendar);
140140
var x, y;
141141

142142
if(xa.showgrid) {
143143
for(k = 0; k < xVals.length; k++) {
144-
x = xoffset + xa.l2p(xVals[k].x);
145-
push('grid', xa, x, yoffset, x, yoffset + ylength);
144+
x = xOffset + xa.l2p(xVals[k].x);
145+
push('grid', xa, x, yOffset, x, yOffset + yLength);
146146
}
147147
}
148148
if(ya.showgrid) {
149149
for(k = 0; k < yVals.length; k++) {
150-
y = yoffset + yb + ym * yVals[k].x;
151-
push('grid', ya, xoffset, y, xoffset + xlength, y);
150+
y = yOffset + yb + ym * yVals[k].x;
151+
push('grid', ya, xOffset, y, xOffset + xLength, y);
152152
}
153153
}
154154
if(shouldShowZeroLine(gd, xa, ya)) {
155-
x = xoffset + xa.l2p(0);
156-
push('zeroline', xa, x, yoffset, x, yoffset + ylength);
155+
x = xOffset + xa.l2p(0);
156+
push('zeroline', xa, x, yOffset, x, yOffset + yLength);
157157
}
158158
if(shouldShowZeroLine(gd, ya, xa)) {
159-
y = yoffset + yb + 0;
160-
push('zeroline', ya, xoffset, y, xoffset + xlength, y);
159+
y = yOffset + yb + 0;
160+
push('zeroline', ya, xOffset, y, xOffset + xLength, y);
161161
}
162162
}
163163

0 commit comments

Comments
 (0)