report coords in input-data space in pt event data

Author: etpinard

src/traces/bar/select.js

@@ -12,6 +12,8 @@ var DESELECTDIM = require('../../constants/interactions').DESELECTDIM;
 
 module.exports = function selectPoints(searchInfo, polygon) {
     var cd = searchInfo.cd;
+    var xa = searchInfo.xaxis;
+    var ya = searchInfo.yaxis;
     var selection = [];
     var trace = cd[0].trace;
     var node3 = cd[0].node3;
@@ -31,8 +33,8 @@ module.exports = function selectPoints(searchInfo, polygon) {
             if(polygon.contains(di.ct)) {
                 selection.push({
                     pointNumber: i,
-                    x: di.x,
-                    y: di.y
+                    x: xa.c2d(di.x),
+                    y: ya.c2d(di.y)
                 });
                 di.dim = 0;
             } else {

src/traces/box/select.js

@@ -38,8 +38,8 @@ module.exports = function selectPoints(searchInfo, polygon) {
                 if(polygon.contains([x, y])) {
                     selection.push({
                         pointNumber: pt.i,
-                        x: pt.x,
-                        y: pt.y
+                        x: xa.c2d(pt.x),
+                        y: ya.c2d(pt.y)
                     });
                     pt.dim = 0;
                 } else {

src/traces/scatter/select.js

@@ -42,8 +42,8 @@ module.exports = function selectPoints(searchInfo, polygon) {
             if(polygon.contains([x, y])) {
                 selection.push({
                     pointNumber: i,
-                    x: di.x,
-                    y: di.y
+                    x: xa.c2d(di.x),
+                    y: ya.c2d(di.y)
                 });
                 di.dim = 0;
             }

src/traces/scattergl/select.js

@@ -41,8 +41,8 @@ module.exports = function selectPoints(searchInfo, polygon) {
             if(polygon.contains([x, y])) {
                 selection.push({
                     pointNumber: i,
-                    x: di.x,
-                    y: di.y
+                    x: xa.c2d(di.x),
+                    y: ya.c2d(di.y)
                 });
                 di.dim = 0;
             }

test/jasmine/tests/select_test.js

@@ -809,6 +809,63 @@ describe('Test select box and lasso per trace:', function() {
         .then(done);
     });
 
+    it('should work for date/category traces', function(done) {
+        var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
+
+        var fig = {
+            data: [{
+                x: ['2017-01-01', '2017-02-01', '2017-03-01'],
+                y: ['a', 'b', 'c']
+            }, {
+                type: 'bar',
+                x: ['2017-01-01', '2017-02-02', '2017-03-01'],
+                y: ['a', 'b', 'c']
+            }],
+            layout: {
+                dragmode: 'lasso',
+                width: 400,
+                height: 400
+            }
+        };
+        addInvisible(fig);
+
+        var x0 = 100;
+        var y0 = 100;
+        var x1 = 250;
+        var y1 = 250;
+
+        Plotly.plot(gd, fig)
+        .then(function() {
+            return _run(
+                [[x0, y0], [x1, y0], [x1, y1], [x0, y1], [x0, y0]],
+                function() {
+                    assertPoints([
+                        [0, '2017-02-01', 'b'],
+                        [1, '2017-02-02', 'b']
+                    ]);
+                },
+                null, LASSOEVENTS, 'date/category lasso'
+            );
+        })
+        .then(function() {
+            return Plotly.relayout(gd, 'dragmode', 'select');
+        })
+        .then(function() {
+            return _run(
+                [[x0, y0], [x1, y1]],
+                function() {
+                    assertPoints([
+                        [0, '2017-02-01', 'b'],
+                        [1, '2017-02-02', 'b']
+                    ]);
+                },
+                null, BOXEVENTS, 'date/category select'
+            );
+        })
+        .catch(fail)
+        .then(done);
+    });
+
     it('should work for histogram traces', function(done) {
         var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
         var assertRanges = makeAssertRanges();
@@ -856,7 +913,7 @@ describe('Test select box and lasso per trace:', function() {
     });
 
     it('should work for box traces', function(done) {
-        var assertPoints = makeAssertPoints(['curveNumber', 'y']);
+        var assertPoints = makeAssertPoints(['curveNumber', 'y', 'x']);
         var assertRanges = makeAssertRanges();
         var assertLassoPoints = makeAssertLassoPoints();
 
@@ -875,9 +932,9 @@ describe('Test select box and lasso per trace:', function() {
                 [[200, 200], [400, 200], [400, 350], [200, 350], [200, 200]],
                 function() {
                     assertPoints([
-                        [0, 0.2], [0, 0.3], [0, 0.5], [0, 0.7],
-                        [1, 0.2], [1, 0.5], [1, 0.7], [1, 0.7],
-                        [2, 0.3], [2, 0.6], [2, 0.6]
+                        [0, 0.2, 'day 2'], [0, 0.3, 'day 2'], [0, 0.5, 'day 2'], [0, 0.7, 'day 2'],
+                        [1, 0.2, 'day 2'], [1, 0.5, 'day 2'], [1, 0.7, 'day 2'], [1, 0.7, 'day 2'],
+                        [2, 0.3, 'day 1'], [2, 0.6, 'day 1'], [2, 0.6, 'day 1']
                     ]);
                     assertLassoPoints([
                         ['day 1', 'day 2', 'day 2', 'day 1', 'day 1'],
@@ -895,9 +952,9 @@ describe('Test select box and lasso per trace:', function() {
                 [[200, 200], [400, 350]],
                 function() {
                     assertPoints([
-                        [0, 0.2], [0, 0.3], [0, 0.5], [0, 0.7],
-                        [1, 0.2], [1, 0.5], [1, 0.7], [1, 0.7],
-                        [2, 0.3], [2, 0.6], [2, 0.6]
+                        [0, 0.2, 'day 2'], [0, 0.3, 'day 2'], [0, 0.5, 'day 2'], [0, 0.7, 'day 2'],
+                        [1, 0.2, 'day 2'], [1, 0.5, 'day 2'], [1, 0.7, 'day 2'], [1, 0.7, 'day 2'],
+                        [2, 0.3, 'day 1'], [2, 0.6, 'day 1'], [2, 0.6, 'day 1']
                     ]);
                     assertRanges([['day 1', 'day 2'], [0.1875, 0.71]]);
                 },