Skip to content

Commit 882e8e3

Browse files
committed
put DESELECTDIM in interactions constants file
1 parent a376817 commit 882e8e3

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

src/constants/interactions.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,8 @@ module.exports = {
1818

1919
// ms between first mousedown and 2nd mouseup to constitute dblclick...
2020
// we don't seem to have access to the system setting
21-
DBLCLICKDELAY: 300
21+
DBLCLICKDELAY: 300,
22+
23+
// opacity dimming fraction for points that are not in selection
24+
DESELECTDIM: 0.2
2225
};

src/traces/scatter/select.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
'use strict';
1111

1212
var subtypes = require('./subtypes');
13-
14-
var DESELECTDIM = 0.2;
13+
var DESELECTDIM = require('../../constants/interactions').DESELECTDIM;
1514

1615
module.exports = function selectPoints(searchInfo, polygon) {
1716
var cd = searchInfo.cd,

src/traces/scattergl/convert.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ var makeBubbleSizeFn = require('../scatter/make_bubble_size_func');
2727
var getTraceColor = require('../scatter/get_trace_color');
2828
var MARKER_SYMBOLS = require('../../constants/gl2d_markers');
2929
var DASHES = require('../../constants/gl2d_dashes');
30+
var DESELECTDIM = require('../../constants/interactions').DESELECTDIM;
3031

3132
var AXES = ['xaxis', 'yaxis'];
32-
var DESELECTDIM = 0.2;
3333
var TRANSPARENT = [0, 0, 0, 0];
3434

3535
function LineWithMarkers(scene, uid) {

src/traces/scattermapbox/convert.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ var Colorscale = require('../../components/colorscale');
1919
var makeBubbleSizeFn = require('../scatter/make_bubble_size_func');
2020
var subTypes = require('../scatter/subtypes');
2121
var convertTextOpts = require('../../plots/mapbox/convert_text_opts');
22+
var DESELECTDIM = require('../../constants/interactions').DESELECTDIM;
2223

2324
var COLOR_PROP = 'circle-color';
2425
var SIZE_PROP = 'circle-radius';
2526
var OPACITY_PROP = 'circle-opacity';
26-
var DESELECTDIM = 0.2;
2727

2828
module.exports = function convert(calcTrace) {
2929
var trace = calcTrace[0].trace;

0 commit comments

Comments
 (0)