Skip to content

Commit 8654c38

Browse files
committed
apply auto default
- fix fill for zero angles - update angle description
1 parent 342c904 commit 8654c38

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/traces/scattermapbox/attributes.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ module.exports = overrideAll({
8989
},
9090
angle: {
9191
valType: 'number',
92-
dflt: null,
92+
dflt: 'auto',
9393
role: 'style',
9494
arrayOk: true,
9595
description: [
96-
'Sets the marker rotation, in degrees clockwise.',
97-
'When it is not defined or using null (i.e. default),',
98-
'no rotation would be applied in perspective views.'
96+
'Sets the marker orientation from true North, in degrees clockwise.',
97+
'When using the *auto* default, no rotation would be applied',
98+
'in perspective views which is different from using a zero angle.'
9999
].join(' ')
100100
},
101101
allowoverlap: {

src/traces/scattermapbox/convert.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ module.exports = function convert(gd, calcTrace) {
104104
'icon-size': trace.marker.size / 10
105105
});
106106

107-
if('angle' in trace.marker) {
107+
if('angle' in trace.marker && trace.marker.angle !== 'auto') {
108108
Lib.extendFlat(symbol.layout, {
109109
// unfortunately cant use {angle} do to this issue:
110110
// https://github.com/mapbox/mapbox-gl-js/issues/873
@@ -258,7 +258,7 @@ function makeSymbolGeoJSON(calcTrace, gd) {
258258
getFillFunc(symbol) :
259259
blankFillFunc;
260260

261-
var fillAngle = (angle) ?
261+
var fillAngle = (angle !== 'auto') ?
262262
getFillFunc(angle, true) :
263263
blankFillFunc;
264264

0 commit comments

Comments
 (0)