Skip to content

Commit 81aac61

Browse files
committed
fixing a performance bottleneck while simplifying code
1 parent 592740b commit 81aac61

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/traces/parcoords/lines.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, dimensions
155155
clearOnly: false
156156
};
157157

158+
var initialDims = dimensions.slice();
159+
158160
var dimensionCount = dimensions.length;
159161
var sampleCount = dimensions.reduce(function(p, n) {return Math.min(p, n.values.length);}, dimensions[0].values.length);
160162

@@ -282,11 +284,6 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, dimensions
282284
return i + offset < dimensions.length;
283285
}
284286

285-
function orig(i) {
286-
var index = dimensions.map(function(v) {return v.originalXIndex;}).indexOf(i);
287-
return dimensions[index];
288-
}
289-
290287
var leftmost, rightmost, lowestX = Infinity, highestX = -Infinity;
291288
for(I = 0; I < panelCount; I++) {
292289
if(dimensions[I].canvasX > highestX) {
@@ -311,7 +308,7 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, dimensions
311308
for(abcd = 0; abcd < 4; abcd++) {
312309
for(d = 0; d < 16; d++) {
313310
dims[loHi][abcd][d] = d + 16 * abcd === index ? 1 : 0;
314-
lims[loHi][abcd][d] = (!context && valid(d, 16 * abcd) ? orig(d + 16 * abcd).filter[loHi] : loHi) + (2 * loHi - 1) * filterEpsilon;
311+
lims[loHi][abcd][d] = (!context && valid(d, 16 * abcd) ? initialDims[d + 16 * abcd].filter[loHi] : loHi) + (2 * loHi - 1) * filterEpsilon;
315312
}
316313
}
317314
}

0 commit comments

Comments
 (0)