Skip to content

Commit 7f7193d

Browse files
committed
a few small tweaks
1 parent c7a7f59 commit 7f7193d

File tree

5 files changed

+4
-12
lines changed

5 files changed

+4
-12
lines changed

src/components/calendars/index.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,7 @@ module.exports = {
240240
zaxis: {calendar: axisAttrs}
241241
},
242242
polar: {
243-
radialaxis: {calendar: axisAttrs},
244-
angularaxis: {calendar: axisAttrs}
243+
radialaxis: {calendar: axisAttrs}
245244
}
246245
},
247246
transforms: {

src/lib/coerce.js

-2
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,6 @@ exports.valObjectMeta = {
178178
description: [
179179
'A number (in degree) between -180 and 180.'
180180
].join(' '),
181-
// TODO maybe add option for 0 to 360??
182-
// e.g. for polar.sector
183181
requiredOpts: [],
184182
otherOpts: ['dflt'],
185183
coerceFunction: function(v, propOut, dflt) {

src/plots/cartesian/axes.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,6 @@ axes.calcTicks = function calcTicks(ax) {
821821
}
822822

823823
// If same angle over a full circle, the last tick vals is a duplicate.
824-
//
825824
// TODO must do something similar for angular date axes.
826825
if(ax._id === 'angular' && Math.abs(rng[1] - rng[0]) === 360) {
827826
vals.pop();
@@ -895,9 +894,7 @@ var roundBase10 = [2, 5, 10],
895894
// these don't have to be exact, just close enough to round to the right value
896895
roundLog1 = [-0.046, 0, 0.301, 0.477, 0.602, 0.699, 0.778, 0.845, 0.903, 0.954, 1],
897896
roundLog2 = [-0.301, 0, 0.301, 0.699, 1],
898-
// TODO
899-
// maybe [1, 2, 5, 10, 15, 30, 45, 90, 180] would give better results
900-
// on thin polar sectors?
897+
// N.B. `thetaunit; 'radians' angular axes must be converted to degrees
901898
roundAngles = [15, 30, 45, 90, 180];
902899

903900
function roundDTick(roughDTick, base, roundingSet) {
@@ -995,7 +992,7 @@ axes.autoTicks = function(ax, roughDTick) {
995992
}
996993
else if(ax._id === 'angular') {
997994
ax.tick0 = 0;
998-
base = getBase(1);
995+
base = 1;
999996
ax.dtick = roundDTick(roughDTick, base, roundAngles);
1000997
}
1001998
else {

src/plots/polar/polar.js

-2
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,9 @@ proto.plot = function(polarCalcData, fullLayout) {
7474
var _this = this;
7575
var polarLayout = fullLayout[_this.id];
7676

77-
// TODO maybe move to generalUpdatePerTraceModule ?
7877
_this._hasClipOnAxisFalse = false;
7978
for(var i = 0; i < polarCalcData.length; i++) {
8079
var trace = polarCalcData[i][0].trace;
81-
8280
if(trace.cliponaxis === false) {
8381
_this._hasClipOnAxisFalse = true;
8482
break;

src/traces/scatterpolar/attributes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ module.exports = {
7777
}),
7878
fillcolor: scatterAttrs.fillcolor,
7979

80-
// TODO (probably not for first push)
80+
// TODO error bars
8181
// https://stackoverflow.com/a/26597487/4068492
8282
// error_x (error_r, error_theta)
8383
// error_y

0 commit comments

Comments
 (0)