Skip to content

Commit 7e16d0f

Browse files
committed
put back test cases that feature run-to-run randomness:
- maybe with new non-zero pixel comparison tolerance, these will behave consistently.
1 parent 479ff83 commit 7e16d0f

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

test/image/compare_pixels_test.js

+8-13
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ var gm = require('gm');
1212
var TOLERANCE = 1e-6; // pixel comparison tolerance
1313
var BASE_TIMEOUT = 500; // base timeout time
1414
var BATCH_SIZE = 5; // size of each test 'batch'
15+
1516
var touch = function(fileName) {
1617
fs.closeSync(fs.openSync(fileName, 'w'));
1718
};
@@ -36,25 +37,19 @@ function runAll() {
3637

3738
var allMocks = fs.readdirSync(constants.pathToTestImageMocks);
3839

39-
/*
40-
* Some test cases exhibit run-to-run randomness;
41-
* skip over these few test cases for now.
40+
/* Test cases:
41+
*
42+
* - font-wishlist
43+
* - all gl2d
4244
*
43-
* More info:
44-
* https://github.com/plotly/plotly.js/issues/62
45+
* don't behave consistently from run-to-run and/or
46+
* machine-to-machine; skip over them.
4547
*
46-
* 41 test cases are removed:
47-
* - font-wishlist (1 test case)
48-
* - all gl2d (38)
49-
* - gl3d_bunny-hull (1)
50-
* - polar_scatter (1)
5148
*/
5249
var mocks = allMocks.filter(function(mock) {
5350
return !(
5451
mock === 'font-wishlist.json' ||
55-
mock.indexOf('gl2d') !== -1 ||
56-
mock === 'gl3d_bunny-hull.json' ||
57-
mock === 'polar_scatter.json'
52+
mock.indexOf('gl2d') !== -1
5853
);
5954
});
6055

0 commit comments

Comments
 (0)