Skip to content

Commit 7858201

Browse files
committed
Simplify line creation method
1 parent 943a743 commit 7858201

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

src/traces/parcoords/lines.js

+13-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,19 @@ function valid(i, offset, panelCount) {
165165
return i + offset <= panelCount;
166166
}
167167

168-
module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, initialDimensions, initialPanels, unitToColor, context, pick, scatter) {
168+
module.exports = function(canvasGL, d, scatter) {
169+
var model = d.model,
170+
vm = d.viewModel;
171+
172+
var lines = model.lines,
173+
canvasWidth = model.canvasWidth,
174+
canvasHeight = model.canvasHeight,
175+
initialDimensions = vm.dimensions,
176+
initialPanels = vm.panels,
177+
unitToColor = model.unitToColor,
178+
context = d.context,
179+
pick = d.pick;
180+
169181

170182
var renderState = {
171183
currentRafs: {},

src/traces/parcoords/parcoords.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ module.exports = function(root, svg, parcoordsLineLayers, styledData, layout, ca
460460

461461
parcoordsLineLayer
462462
.each(function(d) {
463-
d.lineLayer = lineLayerMaker(this, d.model.lines, d.model.canvasWidth, d.model.canvasHeight, d.viewModel.dimensions, d.viewModel.panels, d.model.unitToColor, d.context, d.pick, c.scatter);
463+
d.lineLayer = lineLayerMaker(this, d, c.scatter);
464464
d.viewModel[d.key] = d.lineLayer;
465465
tweakables.renderers.push(function() {d.lineLayer.render(d.viewModel.panels, true);});
466466
d.lineLayer.render(d.viewModel.panels, !d.context);

0 commit comments

Comments
 (0)