Skip to content

Commit 7487dc3

Browse files
committed
typo fixes
1 parent 278ed7c commit 7487dc3

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

CONTRIBUTING.md

+10-11
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ image mocks based on their file name and trace type.
102102
Use the [`plotly-mock-viewer`](https://github.com/rreusser/plotly-mock-viewer)
103103
which has live-reloading and a bunch of other cool features.
104104
An online version of `plotly-mock-viewer` is available at https://rreusser.github.io/plotly-mock-viewer/
105-
which uses the https://cdn.plot.ly/plotly-latest.min.js
105+
which uses https://cdn.plot.ly/plotly-latest.min.js
106106

107107
#### Other npm scripts
108108

@@ -239,7 +239,7 @@ The trace module methods are meant to be called as part of loops during subplot-
239239
(e.g. in `plots/cartesian/index.js`) and figure-wide (e.g. in `plots/plots.js`) subroutines.
240240
That way, the subroutines work no matter which trace modules got registered.
241241

242-
All traces modules defined:
242+
All traces modules set:
243243

244244
- `_module.name`: name of the trace module as used by the trace `type` attribute.
245245
- `_module.basePlotModule`: base plot (or subplot) module corresponding to the
@@ -248,8 +248,8 @@ All traces modules defined:
248248
This object is used to generate the plot-schema JSON.
249249
- `_module.supplyDefaults`: Takes in input trace settings and coerces them into "full" settings
250250
under `gd._fullData`. This one is called during the figure-wide `Plots.supplyDefaults` routine.
251-
Note that the `suppyDefaults` method performance should scale with the number of attribute **not** the
252-
number of data points.
251+
Note that the `suppyDefaults` method performance should scale with the number of attributes (**not** the
252+
number of data points).
253253
- `_module.calc`: Converts inputs data into "calculated" (or sanitized) data. This one is called during
254254
the figure-wide `Plots.doCalcdata` routine. The `calc` method is allowed to
255255
scale with the number of data points and is in general more costly than `supplyDefaults`.
@@ -258,13 +258,13 @@ All traces modules defined:
258258

259259
Other methods used by some trace modules:
260260

261-
- `_module.categories`: list of string identifies used to grouped traces by behavior
261+
- `_module.categories`: list of string identifiers used to group traces by behavior
262262
- `_module.layoutAttributes`: JSON-serializable object of attribute declarations
263-
in the layout (e.g. `barmode` for `bar` traces)
264-
- `_module.supplyLayoutDefaults`: Default logic for layout attributes.
265-
- `_module.crossTraceDefaults`: Default logic that depends on input setting of multiple traces.
263+
coerced in the layout (e.g. `barmode` for `bar` traces)
264+
- `_module.supplyLayoutDefaults`: Defaults logic for layout attributes.
265+
- `_module.crossTraceDefaults`: Defaults logic that depends on input setting of multiple traces.
266266
- `_module.crossTraceCalc`: Computations that depend on the data of multiple traces.
267-
- `_module.colorbar`: Defines the colorbar appearance when the trace supports it.
267+
- `_module.colorbar`: Defines the colorbar appearance for traces that support it.
268268
- `_module.hoverPoints`: Point-picking logic called during hover.
269269
- `_module.selectPoints`: Polygon-containing logic called during selections.
270270
- `_module.style`: Sometimes split from `_module.plot` where `_module.plot` only
@@ -273,8 +273,7 @@ Other methods used by some trace modules:
273273
selections.
274274
- `_module.convert`: Sometimes separated from `_module.plot` or `_module.calc` to convert the
275275
plotly.js settings to another framework e.g. to `gl-plot3d` for `gl3d` traces, to
276-
`mapbox-gl` from `mapbox` traces. This split can also make the logic easier to
277-
test.
276+
`mapbox-gl` from `mapbox` traces. This split can make the logic easier to test.
278277

279278
## Coding style
280279

0 commit comments

Comments
 (0)