Skip to content

Commit 7273e6d

Browse files
authored
Merge pull request #5605 from plotly/fixup-sync-npm-packages
Fix the list of traces for publishing packages to npm
2 parents a5a5de9 + 8ff08ad commit 7273e6d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tasks/sync_packages.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ partialBundlePaths
3434
main: 'plotly-' + d.name + '.js',
3535
dist: d.dist,
3636
desc: 'Ready-to-use plotly.js ' + d.name + ' distributed bundle.',
37+
traceList: constants.partialBundleTraces[d.name]
3738
};
3839
})
3940
.concat([{
@@ -42,6 +43,7 @@ partialBundlePaths
4243
main: 'plotly.js',
4344
dist: constants.pathToPlotlyDist,
4445
desc: 'Ready-to-use plotly.js distributed bundle.',
46+
traceList: constants.allTraces
4547
}])
4648
.forEach(syncPartialBundlePkg);
4749

@@ -54,6 +56,7 @@ partialBundlePaths
5456
main: 'plotly-' + d.name + '.min.js',
5557
dist: d.distMin,
5658
desc: 'Ready-to-use minified plotly.js ' + d.name + ' distributed bundle.',
59+
traceList: constants.partialBundleTraces[d.name]
5760
};
5861
})
5962
.concat([{
@@ -62,6 +65,7 @@ partialBundlePaths
6265
main: 'plotly.min.js',
6366
dist: constants.pathToPlotlyDistMin,
6467
desc: 'Ready-to-use minified plotly.js distributed bundle.',
68+
traceList: constants.allTraces
6569
}])
6670
.forEach(syncPartialBundlePkg);
6771

@@ -105,14 +109,12 @@ function syncPartialBundlePkg(d) {
105109

106110

107111
function writeREADME(cb) {
108-
var traceList = d.traceList;
109-
110112
var cnt = [
111113
'# ' + d.name,
112114
'',
113115
d.desc,
114116
'',
115-
'Contains trace modules ' + common.formatEnumeration(traceList) + '.',
117+
'Contains trace modules ' + common.formatEnumeration(d.traceList) + '.',
116118
'',
117119
'For more info on plotly.js, go to https://github.com/plotly/plotly.js',
118120
'',

tasks/util/constants.js

+2
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,8 @@ module.exports = {
168168
pathToBuild: pathToBuild,
169169
pathToDist: pathToDist,
170170

171+
partialBundleTraces: partialBundleTraces,
172+
171173
allTransforms: allTransforms,
172174
allTraces: allTraces,
173175
mainIndex: mainIndex,

0 commit comments

Comments
 (0)