Skip to content

Commit 701edca

Browse files
committed
Introduce has-passive-events
1 parent 7221cd0 commit 701edca

File tree

6 files changed

+5
-27
lines changed

6 files changed

+5
-27
lines changed

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
"gl-spikes2d": "^1.0.1",
8585
"gl-surface3d": "^1.3.1",
8686
"has-hover": "^1.0.1",
87+
"has-passive-events": "^1.0.0",
8788
"kdgrass": "^1.0.1",
8889
"mapbox-gl": "^0.22.0",
8990
"matrix-camera-controller": "^2.1.3",

src/components/dragelement/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
var mouseOffset = require('mouse-event-offset');
1313
var hasHover = require('has-hover');
14+
var supportsPassive = require('has-passive-events');
1415

1516
var Plotly = require('../../plotly');
1617
var Lib = require('../../lib');
@@ -27,7 +28,6 @@ var unhover = require('./unhover');
2728
dragElement.unhover = unhover.wrapped;
2829
dragElement.unhoverRaw = unhover.raw;
2930

30-
var supportsPassive = Lib.eventListenerOptionsSupported();
3131

3232
/**
3333
* Abstracts click & drag interactions

src/lib/index.js

-22
Original file line numberDiff line numberDiff line change
@@ -890,25 +890,3 @@ lib.subplotSort = function(a, b) {
890890
}
891891
return numB - numA;
892892
};
893-
894-
/*
895-
* test if event listener options supported
896-
*/
897-
lib.eventListenerOptionsSupported = function() {
898-
var supported = false;
899-
900-
try {
901-
var opts = Object.defineProperty({}, 'passive', {
902-
get: function() {
903-
supported = true;
904-
}
905-
});
906-
907-
window.addEventListener('test', null, opts);
908-
window.removeEventListener('test', null, opts);
909-
} catch(e) {
910-
supported = false;
911-
}
912-
913-
return supported;
914-
};

src/plots/cartesian/dragbox.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
var d3 = require('d3');
1313
var tinycolor = require('tinycolor2');
14+
var supportsPassive = require('has-passive-events');
1415

1516
var Plotly = require('../../plotly');
1617
var Registry = require('../../registry');
@@ -34,7 +35,6 @@ var constants = require('./constants');
3435
var MINDRAG = constants.MINDRAG;
3536
var MINZOOM = constants.MINZOOM;
3637

37-
var supportsPassive = Lib.eventListenerOptionsSupported();
3838

3939
// flag for showing "doubleclick to zoom out" only at the beginning
4040
var SHOWZOOMOUTTIP = true;

src/plots/gl3d/camera.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ var createView = require('3d-view');
1515
var mouseChange = require('mouse-change');
1616
var mouseWheel = require('mouse-wheel');
1717
var mouseOffset = require('mouse-event-offset');
18-
var Lib = require('../../lib');
19-
var supportsPassive = Lib.eventListenerOptionsSupported();
18+
var supportsPassive = require('has-passive-events');
2019

2120
function createCamera(element, options) {
2221
element = element || document.body;

src/plots/gl3d/scene.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
var createPlot = require('gl-plot3d');
1313
var getContext = require('webgl-context');
14+
var passiveSupported = require('has-passive-events');
1415

1516
var Registry = require('../../registry');
1617
var Lib = require('../../lib');
@@ -27,7 +28,6 @@ var createAxesOptions = require('./layout/convert');
2728
var createSpikeOptions = require('./layout/spikes');
2829
var computeTickMarks = require('./layout/tick_marks');
2930

30-
var passiveSupported = Lib.eventListenerOptionsSupported();
3131

3232
var STATIC_CANVAS, STATIC_CONTEXT;
3333

0 commit comments

Comments
 (0)