Skip to content

Commit 6b8d461

Browse files
committed
drop domain and grid editTypes from calc to plot
1 parent 670bdd5 commit 6b8d461

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

src/plots/cartesian/layout_attributes.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -685,11 +685,11 @@ module.exports = {
685685
valType: 'info_array',
686686
role: 'info',
687687
items: [
688-
{valType: 'number', min: 0, max: 1, editType: 'calc'},
689-
{valType: 'number', min: 0, max: 1, editType: 'calc'}
688+
{valType: 'number', min: 0, max: 1, editType: 'plot'},
689+
{valType: 'number', min: 0, max: 1, editType: 'plot'}
690690
],
691691
dflt: [0, 1],
692-
editType: 'calc',
692+
editType: 'plot',
693693
description: [
694694
'Sets the domain of this axis (in plot fraction).'
695695
].join(' ')

src/plots/grid.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ var gridAttrs = exports.attributes = {
1919
valType: 'integer',
2020
min: 1,
2121
role: 'info',
22-
editType: 'calc',
22+
editType: 'plot',
2323
description: [
2424
'The number of rows in the grid. If you provide a 2D `subplots`',
2525
'array or a `yaxes` array, its length is used as the default.',
@@ -32,7 +32,7 @@ var gridAttrs = exports.attributes = {
3232
values: ['top to bottom', 'bottom to top'],
3333
dflt: 'top to bottom',
3434
role: 'info',
35-
editType: 'calc',
35+
editType: 'plot',
3636
description: [
3737
'Is the first row the top or the bottom? Note that columns',
3838
'are always enumerated from left to right.'
@@ -42,7 +42,7 @@ var gridAttrs = exports.attributes = {
4242
valType: 'integer',
4343
min: 1,
4444
role: 'info',
45-
editType: 'calc',
45+
editType: 'plot',
4646
description: [
4747
'The number of columns in the grid. If you provide a 2D `subplots`',
4848
'array, the length of its longest row is used as the default.',
@@ -57,7 +57,7 @@ var gridAttrs = exports.attributes = {
5757
dimensions: 2,
5858
items: {valType: 'enumerated', values: [counterRegex('xy').toString(), '']},
5959
role: 'info',
60-
editType: 'calc',
60+
editType: 'plot',
6161
description: [
6262
'Used for freeform grids, where some axes may be shared across subplots',
6363
'but others are not. Each entry should be a cartesian subplot id, like',
@@ -72,7 +72,7 @@ var gridAttrs = exports.attributes = {
7272
freeLength: true,
7373
items: {valType: 'enumerated', values: [cartesianIdRegex.x.toString(), '']},
7474
role: 'info',
75-
editType: 'calc',
75+
editType: 'plot',
7676
description: [
7777
'Used with `yaxes` when the x and y axes are shared across columns and rows.',
7878
'Each entry should be an x axis id like *x*, *x2*, etc., or ** to',
@@ -86,7 +86,7 @@ var gridAttrs = exports.attributes = {
8686
freeLength: true,
8787
items: {valType: 'enumerated', values: [cartesianIdRegex.y.toString(), '']},
8888
role: 'info',
89-
editType: 'calc',
89+
editType: 'plot',
9090
description: [
9191
'Used with `yaxes` when the x and y axes are shared across columns and rows.',
9292
'Each entry should be an y axis id like *y*, *y2*, etc., or ** to',
@@ -100,7 +100,7 @@ var gridAttrs = exports.attributes = {
100100
values: ['independent', 'coupled'],
101101
dflt: 'coupled',
102102
role: 'info',
103-
editType: 'calc',
103+
editType: 'plot',
104104
description: [
105105
'If no `subplots`, `xaxes`, or `yaxes` are given but we do have `rows` and `columns`,',
106106
'we can generate defaults using consecutive axis IDs, in two ways:',
@@ -114,7 +114,7 @@ var gridAttrs = exports.attributes = {
114114
min: 0,
115115
max: 1,
116116
role: 'info',
117-
editType: 'calc',
117+
editType: 'plot',
118118
description: [
119119
'Horizontal space between grid cells, expressed as a fraction',
120120
'of the total width available to one cell. Defaults to 0.1',
@@ -126,14 +126,14 @@ var gridAttrs = exports.attributes = {
126126
min: 0,
127127
max: 1,
128128
role: 'info',
129-
editType: 'calc',
129+
editType: 'plot',
130130
description: [
131131
'Vertical space between grid cells, expressed as a fraction',
132132
'of the total height available to one cell. Defaults to 0.1',
133133
'for coupled-axes grids and 0.3 for independent grids.'
134134
].join(' ')
135135
},
136-
domain: domainAttrs({name: 'grid', editType: 'calc', noGridCell: true}, {
136+
domain: domainAttrs({name: 'grid', editType: 'plot', noGridCell: true}, {
137137
description: [
138138
'The first and last cells end exactly at the domain',
139139
'edges, with no grout around the edges.'
@@ -163,7 +163,7 @@ var gridAttrs = exports.attributes = {
163163
'that each y axis is used in. *right* and *right plot* are similar.'
164164
].join(' ')
165165
},
166-
editType: 'calc'
166+
editType: 'plot'
167167
};
168168

169169
// the shape of the grid - this needs to be done BEFORE supplyDataDefaults

0 commit comments

Comments
 (0)