Skip to content

Commit 6a44a9a

Browse files
committed
fix panning on text chart with invalid array values
1 parent 7f2604a commit 6a44a9a

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/components/drawing/index.js

+3
Original file line numberDiff line numberDiff line change
@@ -887,6 +887,9 @@ drawing.setTextPointsScale = function(selection, xScale, yScale) {
887887
var transforms;
888888
var el = d3.select(this);
889889
var text = el.select('text');
890+
891+
if(!text.node()) return;
892+
890893
var x = parseFloat(text.attr('x') || 0);
891894
var y = parseFloat(text.attr('y') || 0);
892895

test/jasmine/tests/drawing_test.js

+5
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,11 @@ describe('Drawing', function() {
345345
Drawing.setTextPointsScale(g, 4, 5);
346346
expect(g.attr('transform')).toEqual('translate(8,9) scale(4,5) translate(-8,-9) translate(1, 2)');
347347
});
348+
349+
it('should not break when <text> is not present', function() {
350+
text.remove();
351+
expect(function() { Drawing.setTextPointsScale(g, 4, 5); }).not.toThrow();
352+
});
348353
});
349354

350355
describe('bBox', function() {

0 commit comments

Comments
 (0)