Skip to content

Commit 69bf7eb

Browse files
committed
remove extra loop - update comments
1 parent c00d56e commit 69bf7eb

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/components/legend/get_legend_data.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,19 @@ module.exports = function getLegendData(calcdata, opts) {
8686
}
8787
if(shouldCollapse) legendData = [legendData];
8888

89-
// sort considering trace.legendrank and legend.traceorder
9089
var orderFn = function(a, b) {
9190
return a.trace.legendrank - b.trace.legendrank;
9291
};
9392
for(i = 0; i < legendData.length; i++) {
93+
// sort considering trace.legendrank and legend.traceorder
9494
legendData[i].sort(orderFn);
9595
if(reversed) legendData[i].reverse();
96-
}
9796

98-
for(i = 0; i < legendData.length; i++) {
97+
// add extra dim
9998
for(j = 0; j < legendData[i].length; j++) {
100-
legendData[i][j] = [legendData[i][j]];
99+
legendData[i][j] = [
100+
legendData[i][j]
101+
];
101102
}
102103
}
103104

0 commit comments

Comments
 (0)