Skip to content

Commit 66346bc

Browse files
committed
Fix plots test to work with internal event handler
1 parent edae9fc commit 66346bc

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/lib/events.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ var Events = {
131131
* events internally.
132132
*/
133133
var internalHandlers = plotObj._internalEv._events[event];
134-
if (internalHandlers) {
134+
if(internalHandlers) {
135135
if(typeof internalHandlers === 'function') internalHandlers = [internalHandlers];
136136
for(i = 0; i < internalHandlers.length; i++) {
137137
internalHandlers[i](data);
@@ -165,7 +165,7 @@ var Events = {
165165
delete plotObj._internalOn;
166166
delete plotObj._internalOnce;
167167
delete plotObj._removeInternalListener;
168-
delete plotObj._removeAllInternalListeners;;
168+
delete plotObj._removeAllInternalListeners;
169169

170170
return plotObj;
171171
}

test/jasmine/tests/plots_test.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,10 @@ describe('Test Plots', function() {
301301

302302
it('should unset everything in the gd except _context', function() {
303303
var expectedKeys = [
304-
'_ev', 'on', 'once', 'removeListener', 'removeAllListeners',
305-
'emit', '_context', '_replotPending', '_mouseDownTime',
306-
'_hmpixcount', '_hmlumcount'
304+
'_ev', '_internalEv', 'on', 'once', 'removeListener', 'removeAllListeners',
305+
'_internalOn', '_internalOnce', '_removeInternalListener',
306+
'_removeAllInternalListeners', 'emit', '_context', '_replotPending',
307+
'_mouseDownTime', '_hmpixcount', '_hmlumcount'
307308
];
308309

309310
Plots.purge(gd);

0 commit comments

Comments
 (0)