Skip to content

Commit 65ffb52

Browse files
committed
require only range slider/selector default handlers cartesian defaults
- so that they are called only when the range slider/selector components are registered
1 parent 0aa87c4 commit 65ffb52

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/plots/cartesian/layout_defaults.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ var Lib = require('../../lib');
1414
var Color = require('../../components/color');
1515
var basePlotLayoutAttributes = require('../layout_attributes');
1616

17-
var RangeSlider = require('../../components/rangeslider');
18-
var RangeSelector = require('../../components/rangeselector');
19-
2017
var constants = require('./constants');
2118
var layoutAttributes = require('./layout_attributes');
2219
var handleAxisDefaults = require('./axis_defaults');
@@ -157,16 +154,19 @@ module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) {
157154
});
158155

159156
// quick second pass for range slider and selector defaults
157+
var rangeSliderDefaults = Registry.getComponentMethod('rangeslider', 'handleDefaults'),
158+
rangeSelectorDefaults = Registry.getComponentMethod('rangeselector', 'handleDefaults');
159+
160160
axesList.forEach(function(axName) {
161161
var axLetter = axName.charAt(0),
162162
axLayoutIn = layoutIn[axName],
163163
axLayoutOut = layoutOut[axName],
164164
counterAxes = {x: yaList, y: xaList}[axLetter];
165165

166-
RangeSlider.supplyLayoutDefaults(layoutIn, layoutOut, axName, counterAxes);
166+
rangeSliderDefaults(layoutIn, layoutOut, axName, counterAxes);
167167

168168
if(axLetter === 'x' && axLayoutOut.type === 'date') {
169-
RangeSelector.supplyLayoutDefaults(axLayoutIn, axLayoutOut, layoutOut, counterAxes);
169+
rangeSelectorDefaults(axLayoutIn, axLayoutOut, layoutOut, counterAxes);
170170
}
171171
});
172172
};

0 commit comments

Comments
 (0)