Skip to content

Commit 65da615

Browse files
committed
more role removal
1 parent 6b43933 commit 65da615

File tree

4 files changed

+3
-12
lines changed

4 files changed

+3
-12
lines changed

src/components/colorbar/attributes.js

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ module.exports = overrideAll({
1818
// TODO: only right is supported currently
1919
// orient: {
2020
// valType: 'enumerated',
21-
// role: 'info',
2221
// values: ['left', 'right', 'top', 'bottom'],
2322
// dflt: 'right',
2423
// description: [

src/plot_api/plot_schema.js

+3-9
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ exports.get = function() {
6363
return {
6464
defs: {
6565
valObjects: valObjectMeta,
66-
metaKeys: UNDERSCORE_ATTRS.concat(['description', 'role', 'editType', 'impliedEdits']),
66+
metaKeys: UNDERSCORE_ATTRS.concat(['description', 'editType', 'impliedEdits']),
6767
editType: {
6868
traces: editTypes.traces,
6969
layout: editTypes.layout
@@ -600,14 +600,14 @@ function getFramesAttributes() {
600600
}
601601

602602
function formatAttributes(attrs) {
603-
mergeValTypeAndRole(attrs);
603+
mergeValType(attrs);
604604
formatArrayContainers(attrs);
605605
stringify(attrs);
606606

607607
return attrs;
608608
}
609609

610-
function mergeValTypeAndRole(attrs) {
610+
function mergeValType(attrs) {
611611
function makeSrcAttr(attrName) {
612612
return {
613613
valType: 'string',
@@ -622,17 +622,12 @@ function mergeValTypeAndRole(attrs) {
622622
function callback(attr, attrName, attrs) {
623623
if(exports.isValObject(attr)) {
624624
if(attr.valType === 'data_array') {
625-
// all 'data_array' attrs have role 'data'
626-
attr.role = 'data';
627625
// all 'data_array' attrs have a corresponding 'src' attr
628626
attrs[attrName + 'src'] = makeSrcAttr(attrName);
629627
} else if(attr.arrayOk === true) {
630628
// all 'arrayOk' attrs have a corresponding 'src' attr
631629
attrs[attrName + 'src'] = makeSrcAttr(attrName);
632630
}
633-
} else if(isPlainObject(attr)) {
634-
// all attrs container objects get role 'object'
635-
attr.role = 'object';
636631
}
637632
}
638633

@@ -651,7 +646,6 @@ function formatArrayContainers(attrs) {
651646

652647
attrs[attrName] = { items: {} };
653648
attrs[attrName].items[itemName] = attr;
654-
attrs[attrName].role = 'object';
655649
}
656650

657651
exports.crawl(attrs, callback);

src/traces/barpolar/attributes.js

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ module.exports = {
2424

2525
// orientation: {
2626
// valType: 'enumerated',
27-
// role: 'info',
2827
// values: ['radial', 'angular'],
2928
// editType: 'calc+clearAxisTypes',
3029
// description: 'Sets the orientation of the bars.'

src/traces/streamtube/attributes.js

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ var attrs = {
9595
// valType: 'enumerated',
9696
// values: ['scaled', 'absolute', 'fixed'],
9797
// dflt: 'scaled',
98-
// role: 'info',
9998
// editType: 'calc',
10099
// description: [
101100
// 'Sets the mode by which the streamtubes are sized.'

0 commit comments

Comments
 (0)