Skip to content

Commit 648c3c9

Browse files
alexhartstonealexhartstone
committed
5291: fix syntax errors
1 parent 8796f1b commit 648c3c9

File tree

3 files changed

+30
-46
lines changed

3 files changed

+30
-46
lines changed

‎src/components/fx/hover.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ function _hover(gd, evt, subplot, noHoverEvent) {
339339

340340
xpx = evt.clientX - dbb.left;
341341
ypx = evt.clientY - dbb.top;
342-
342+
343343
fullLayout._calcInverseTransform(gd);
344344
var transformedCoords = Lib.apply3DTransform(fullLayout._inverseTransform)(xpx, ypx);
345345

‎src/plot_api/plot_api.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3710,10 +3710,10 @@ function purge(gd) {
37103710
function calcInverseTransform(gd, newBBox) {
37113711
gd = Lib.getGraphDiv(gd);
37123712
var fullLayout = gd._fullLayout;
3713-
if (!newBBox)
3714-
newBBox = gd.getBoundingClientRect();
3715-
if (Lib.domRectsAreEqual(newBBox, fullLayout._lastBBox))
3716-
return;
3713+
if(!newBBox) newBBox = gd.getBoundingClientRect();
3714+
3715+
if(Lib.domRectsAreEqual(newBBox, fullLayout._lastBBox)) return;
3716+
37173717
var m = fullLayout._inverseTransform = Lib.inverseTransformMatrix(Lib.getFullTransformMatrix(gd));
37183718
fullLayout._inverseScaleX = Math.sqrt(m[0][0] * m[0][0] + m[0][1] * m[0][1] + m[0][2] * m[0][2]);
37193719
fullLayout._inverseScaleY = Math.sqrt(m[1][0] * m[1][0] + m[1][1] * m[1][1] + m[1][2] * m[1][2]);

‎test/jasmine/tests/select_test.js

Lines changed: 25 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1851,7 +1851,7 @@ describe('Test select box and lasso per trace:', function() {
18511851
dblClickPos = dblClickPos || [250, 200];
18521852

18531853
var scale = 1;
1854-
if (hasCssTransform){
1854+
if(hasCssTransform) {
18551855
scale = 0.5;
18561856
}
18571857
dblClickPos[0] *= scale;
@@ -1896,8 +1896,7 @@ describe('Test select box and lasso per trace:', function() {
18961896

18971897
Plotly.plot(gd, fig)
18981898
.then(function() {
1899-
if (hasCssTransform)
1900-
transformPlot(gd, cssTransform);
1899+
if(hasCssTransform) transformPlot(gd, cssTransform);
19011900
})
19021901
.then(function() {
19031902
return _run(hasCssTransform,
@@ -1956,8 +1955,7 @@ describe('Test select box and lasso per trace:', function() {
19561955

19571956
Plotly.plot(gd, fig)
19581957
.then(function() {
1959-
if (hasCssTransform)
1960-
transformPlot(gd, cssTransform);
1958+
if(hasCssTransform) transformPlot(gd, cssTransform);
19611959
})
19621960
.then(function() {
19631961
return _run(hasCssTransform,
@@ -2005,8 +2003,11 @@ describe('Test select box and lasso per trace:', function() {
20052003
};
20062004
addInvisible(fig);
20072005

2008-
if (hasCssTransform)transformPlot(gd, cssTransform);
2009-
Plotly.plot(gd, fig).then(function() {
2006+
Plotly.plot(gd, fig)
2007+
.then(function() {
2008+
if(hasCssTransform) transformPlot(gd, cssTransform);
2009+
})
2010+
.then(function() {
20102011
return _run(hasCssTransform,
20112012
[[370, 120], [500, 200]],
20122013
function() {
@@ -2066,8 +2067,7 @@ describe('Test select box and lasso per trace:', function() {
20662067

20672068
Plotly.plot(gd, fig)
20682069
.then(function() {
2069-
if (hasCssTransform)
2070-
transformPlot(gd, cssTransform);
2070+
if(hasCssTransform) transformPlot(gd, cssTransform);
20712071
})
20722072
.then(function() {
20732073
return _run(hasCssTransform,
@@ -2142,8 +2142,7 @@ describe('Test select box and lasso per trace:', function() {
21422142

21432143
Plotly.plot(gd, fig)
21442144
.then(function() {
2145-
if (hasCssTransform)
2146-
transformPlot(gd, cssTransform);
2145+
if(hasCssTransform) transformPlot(gd, cssTransform);
21472146
})
21482147
.then(function() {
21492148
return _run(hasCssTransform,
@@ -2219,8 +2218,7 @@ describe('Test select box and lasso per trace:', function() {
22192218

22202219
Plotly.plot(gd, fig)
22212220
.then(function() {
2222-
if (hasCssTransform)
2223-
transformPlot(gd, cssTransform);
2221+
if(hasCssTransform) transformPlot(gd, cssTransform);
22242222
})
22252223
.then(function() {
22262224
return _run(hasCssTransform,
@@ -2266,8 +2264,7 @@ describe('Test select box and lasso per trace:', function() {
22662264

22672265
Plotly.plot(gd, fig)
22682266
.then(function() {
2269-
if (hasCssTransform)
2270-
transformPlot(gd, cssTransform);
2267+
if(hasCssTransform) transformPlot(gd, cssTransform);
22712268
})
22722269
.then(function() {
22732270
return _run(hasCssTransform,
@@ -2338,8 +2335,7 @@ describe('Test select box and lasso per trace:', function() {
23382335

23392336
Plotly.plot(gd, fig)
23402337
.then(function() {
2341-
if (hasCssTransform)
2342-
transformPlot(gd, cssTransform);
2338+
if(hasCssTransform) transformPlot(gd, cssTransform);
23432339
})
23442340
.then(function() {
23452341
return _run(hasCssTransform,
@@ -2397,8 +2393,7 @@ describe('Test select box and lasso per trace:', function() {
23972393

23982394
Plotly.plot(gd, fig)
23992395
.then(function() {
2400-
if (hasCssTransform)
2401-
transformPlot(gd, cssTransform);
2396+
if(hasCssTransform) transformPlot(gd, cssTransform);
24022397
})
24032398
.then(function() {
24042399
return _run(hasCssTransform,
@@ -2461,8 +2456,7 @@ describe('Test select box and lasso per trace:', function() {
24612456

24622457
Plotly.plot(gd, fig)
24632458
.then(function() {
2464-
if (hasCssTransform)
2465-
transformPlot(gd, cssTransform);
2459+
if(hasCssTransform) transformPlot(gd, cssTransform);
24662460
})
24672461
.then(function() {
24682462
return _run(hasCssTransform,
@@ -2527,8 +2521,7 @@ describe('Test select box and lasso per trace:', function() {
25272521

25282522
Plotly.plot(gd, fig)
25292523
.then(function() {
2530-
if (hasCssTransform)
2531-
transformPlot(gd, cssTransform);
2524+
if(hasCssTransform) transformPlot(gd, cssTransform);
25322525
})
25332526
.then(function() {
25342527
return _run(hasCssTransform,
@@ -2637,8 +2630,7 @@ describe('Test select box and lasso per trace:', function() {
26372630

26382631
Plotly.plot(gd, fig)
26392632
.then(function() {
2640-
if (hasCssTransform)
2641-
transformPlot(gd, cssTransform);
2633+
if(hasCssTransform) transformPlot(gd, cssTransform);
26422634
})
26432635
.then(function() {
26442636
return _run(hasCssTransform,
@@ -2689,8 +2681,7 @@ describe('Test select box and lasso per trace:', function() {
26892681

26902682
Plotly.plot(gd, fig)
26912683
.then(function() {
2692-
if (hasCssTransform)
2693-
transformPlot(gd, cssTransform);
2684+
if(hasCssTransform) transformPlot(gd, cssTransform);
26942685
})
26952686
.then(function() {
26962687
return _run(hasCssTransform,
@@ -2748,8 +2739,7 @@ describe('Test select box and lasso per trace:', function() {
27482739

27492740
Plotly.plot(gd, fig)
27502741
.then(function() {
2751-
if (hasCssTransform)
2752-
transformPlot(gd, cssTransform);
2742+
if(hasCssTransform) transformPlot(gd, cssTransform);
27532743
})
27542744
.then(function() {
27552745
return _run(hasCssTransform,
@@ -2824,8 +2814,7 @@ describe('Test select box and lasso per trace:', function() {
28242814

28252815
Plotly.plot(gd, fig)
28262816
.then(function() {
2827-
if (hasCssTransform)
2828-
transformPlot(gd, cssTransform);
2817+
if(hasCssTransform) transformPlot(gd, cssTransform);
28292818
})
28302819
.then(function() {
28312820
return _run(hasCssTransform,
@@ -2870,8 +2859,7 @@ describe('Test select box and lasso per trace:', function() {
28702859

28712860
Plotly.plot(gd, fig)
28722861
.then(function() {
2873-
if (hasCssTransform)
2874-
transformPlot(gd, cssTransform);
2862+
if(hasCssTransform) transformPlot(gd, cssTransform);
28752863
})
28762864
.then(function() {
28772865
return _run(hasCssTransform,
@@ -2968,8 +2956,7 @@ describe('Test select box and lasso per trace:', function() {
29682956
dragmode: 'lasso'
29692957
})
29702958
.then(function() {
2971-
if (hasCssTransform)
2972-
transformPlot(gd, cssTransform);
2959+
if(hasCssTransform) transformPlot(gd, cssTransform);
29732960
})
29742961
.then(function() {
29752962
return _run(hasCssTransform,
@@ -3038,8 +3025,7 @@ describe('Test select box and lasso per trace:', function() {
30383025
margin: {l: 0, t: 0, r: 0, b: 0}
30393026
})
30403027
.then(function() {
3041-
if (hasCssTransform)
3042-
transformPlot(gd, cssTransform);
3028+
if(hasCssTransform) transformPlot(gd, cssTransform);
30433029
})
30443030
.then(function() {
30453031
return _run(hasCssTransform,
@@ -3091,8 +3077,7 @@ describe('Test select box and lasso per trace:', function() {
30913077
margin: {l: 0, t: 0, r: 0, b: 0}
30923078
})
30933079
.then(function() {
3094-
if (hasCssTransform)
3095-
transformPlot(gd, cssTransform);
3080+
if(hasCssTransform) transformPlot(gd, cssTransform);
30963081
})
30973082
.then(function() {
30983083
return _run(hasCssTransform,
@@ -3123,8 +3108,7 @@ describe('Test select box and lasso per trace:', function() {
31233108

31243109
Plotly.plot(gd, fig)
31253110
.then(function() {
3126-
if (hasCssTransform)
3127-
transformPlot(gd, cssTransform);
3111+
if(hasCssTransform) transformPlot(gd, cssTransform);
31283112
})
31293113
.then(function() {
31303114
// No groups initially

0 commit comments

Comments
 (0)