Skip to content

Commit 635e368

Browse files
committed
unexposed verticalPadding
(cherry picked from commit e9b4d9d)
1 parent a4ba03d commit 635e368

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

src/traces/parcoords/attributes.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -188,15 +188,6 @@ module.exports = {
188188
description: [
189189
'By default, the rendered lines are opaque. Setting it to `true` is necessary if opacity is needed.'
190190
].join(' ')
191-
},
192-
193-
verticalpadding: {
194-
valType: 'number',
195-
dflt: 2,
196-
min: 0,
197-
max: 4,
198-
role: 'style',
199-
description: 'Lines have thickness, and without padding, horizontal lines at extreme values appear thinner.'
200191
}
201192
}
202193
};

src/traces/parcoords/defaults.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,5 +89,4 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
8989
coerce('lines.contextopacity');
9090
coerce('lines.pixelratio');
9191
coerce('lines.focusalphablending');
92-
coerce('lines.verticalpadding');
9392
};

src/traces/parcoords/parcoords.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ var d3 = require('d3');
1515
var overdrag = 40;
1616
var legendWidth = 80;
1717
var integerPadding = 0;
18+
var verticalPadding = 2; // otherwise, horizontal lines on top or bottom are of lower width
1819

1920
var filterBar = {
2021
width: 4, // Visible width of the filter bar
@@ -134,7 +135,7 @@ function viewModel(model) {
134135

135136
var xScale = d3.scale.ordinal().domain(d3.range(dimensions.filter(visible).length)).rangePoints([0, width], 0);
136137

137-
var unitPad = lines.verticalpadding / (height * canvasPixelRatio);
138+
var unitPad = verticalPadding / (height * canvasPixelRatio);
138139
var unitPadScale = (1 - 2 * unitPad);
139140
var paddedUnitScale = function(d) {return unitPad + unitPadScale * d;};
140141

@@ -159,8 +160,8 @@ function viewModel(model) {
159160
xScale: xScale,
160161
x: xScale(i),
161162
canvasX: xScale(i) * canvasPixelRatio,
162-
unitScale: unitScale(height, lines.verticalpadding),
163-
domainScale: domainScale(height, lines.verticalpadding, integerPadding, dimension),
163+
unitScale: unitScale(height, verticalPadding),
164+
domainScale: domainScale(height, verticalPadding, integerPadding, dimension),
164165
integerScale: integerScale(lines.integerpadding, dimension),
165166
domainToUnitScale: domainToUnit,
166167
pieChartCheat: dimension.pieChartCheat,

0 commit comments

Comments
 (0)