Skip to content

Commit 6077f9a

Browse files
committed
we don't reuse scatter files ... because partialy impelemented
1 parent 6a9afa1 commit 6077f9a

File tree

3 files changed

+27
-3
lines changed

3 files changed

+27
-3
lines changed

src/traces/scattergl/attributes.js

+11-2
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,17 @@ var attrs = module.exports = overrideAll({
5454
line: {
5555
color: scatterLineAttrs.color,
5656
width: scatterLineAttrs.width,
57-
shape: scatterLineAttrs.shape,
58-
smoothing: scatterLineAttrs.smoothing,
57+
shape: {
58+
valType: 'enumerated',
59+
values: ['linear', 'hv', 'vh', 'hvh', 'vhv'],
60+
dflt: 'linear',
61+
role: 'style',
62+
editType: 'plot',
63+
description: [
64+
'Determines the line shape.',
65+
'The values correspond to step-wise line shapes.'
66+
].join(' ')
67+
},
5968
dash: {
6069
valType: 'enumerated',
6170
values: Object.keys(DASHES),

src/traces/scattergl/defaults.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var subTypes = require('../scatter/subtypes');
1717
var handleXYDefaults = require('../scatter/xy_defaults');
1818
var handleMarkerDefaults = require('../scatter/marker_defaults');
1919
var handleLineDefaults = require('../scatter/line_defaults');
20-
var handleLineShapeDefaults = require('../scatter/line_shape_defaults');
20+
var handleLineShapeDefaults = require('./line_shape_defaults');
2121
var handleFillColorDefaults = require('../scatter/fillcolor_defaults');
2222
var handleTextDefaults = require('../scatter/text_defaults');
2323

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
/**
2+
* Copyright 2012-2018, Plotly, Inc.
3+
* All rights reserved.
4+
*
5+
* This source code is licensed under the MIT license found in the
6+
* LICENSE file in the root directory of this source tree.
7+
*/
8+
9+
10+
'use strict';
11+
12+
module.exports = function handleLineShapeDefaults(traceIn, traceOut, coerce) {
13+
var shape = coerce('line.shape');
14+
};
15+

0 commit comments

Comments
 (0)