Skip to content

Commit 5eaf29d

Browse files
committed
separate heatmapgl supplyDefaults from heatmap
- use heatmapgl attributes not heatmap - only coerce valid heatmapgl attributes not heatmap attributes
1 parent 3451056 commit 5eaf29d

File tree

2 files changed

+34
-1
lines changed

2 files changed

+34
-1
lines changed

src/traces/heatmapgl/defaults.js

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
/**
2+
* Copyright 2012-2020, Plotly, Inc.
3+
* All rights reserved.
4+
*
5+
* This source code is licensed under the MIT license found in the
6+
* LICENSE file in the root directory of this source tree.
7+
*/
8+
9+
10+
'use strict';
11+
12+
var Lib = require('../../lib');
13+
14+
var handleXYZDefaults = require('../heatmap/xyz_defaults');
15+
var colorscaleDefaults = require('../../components/colorscale/defaults');
16+
var attributes = require('./attributes');
17+
18+
19+
module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
20+
function coerce(attr, dflt) {
21+
return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
22+
}
23+
24+
var validData = handleXYZDefaults(traceIn, traceOut, coerce, layout);
25+
if(!validData) {
26+
traceOut.visible = false;
27+
return;
28+
}
29+
30+
coerce('text');
31+
32+
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'z'});
33+
};

src/traces/heatmapgl/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
module.exports = {
1212
attributes: require('./attributes'),
13-
supplyDefaults: require('../heatmap/defaults'),
13+
supplyDefaults: require('./defaults'),
1414
colorbar: require('../heatmap/colorbar'),
1515

1616
calc: require('../heatmap/calc'),

0 commit comments

Comments
 (0)