refactor parcoords - use general variable names in plot and base_plot

Author: archmoj

src/traces/parcoords/base_plot.js

@@ -13,18 +13,16 @@ var getModuleCalcData = require('../../plots/get_data').getModuleCalcData;
 var parcoordsPlot = require('./plot');
 var xmlnsNamespaces = require('../../constants/xmlns_namespaces');
 
-var PARCOORDS = 'parcoords';
-
-exports.name = PARCOORDS;
+exports.name = 'parcoords';
 
 exports.plot = function(gd) {
-    var calcData = getModuleCalcData(gd.calcdata, PARCOORDS)[0];
+    var calcData = getModuleCalcData(gd.calcdata, 'parcoords')[0];
     if(calcData.length) parcoordsPlot(gd, calcData);
 };
 
 exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout) {
-    var hadParcoords = (oldFullLayout._has && oldFullLayout._has(PARCOORDS));
-    var hasParcoords = (newFullLayout._has && newFullLayout._has(PARCOORDS));
+    var hadParcoords = (oldFullLayout._has && oldFullLayout._has('parcoords'));
+    var hasParcoords = (newFullLayout._has && newFullLayout._has('parcoords'));
 
     if(hadParcoords && !hasParcoords) {
         oldFullLayout._paperdiv.selectAll('.parcoords').remove();

src/traces/parcoords/plot.js

@@ -11,7 +11,7 @@
 var parcoords = require('./parcoords');
 var prepareRegl = require('../../lib/prepare_regl');
 
-module.exports = function plot(gd, cdparcoords) {
+module.exports = function plot(gd, cdModule) {
     var fullLayout = gd._fullLayout;
     var svg = fullLayout._toppaper;
     var root = fullLayout._paperdiv;
@@ -27,7 +27,7 @@ module.exports = function plot(gd, cdparcoords) {
 
     var size = fullLayout._size;
 
-    cdparcoords.forEach(function(d, i) {
+    cdModule.forEach(function(d, i) {
         var trace = d[0].trace;
         fullIndices[i] = trace.index;
         var iIn = inputIndices[i] = trace._fullInput.index;
@@ -138,7 +138,7 @@ module.exports = function plot(gd, cdparcoords) {
         root,
         svg,
         container,
-        cdparcoords,
+        cdModule,
         {
             width: size.w,
             height: size.h,