Skip to content

Commit 5ae9e1e

Browse files
committed
Merge branch 'master' into period-positioning
2 parents 222b5fe + 86f5e2d commit 5ae9e1e

12 files changed

+670
-80
lines changed

package-lock.json

+113-62
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
"derequire": "^2.1.1",
135135
"ecstatic": "^4.1.4",
136136
"elliptic": "^6.5.3",
137-
"eslint": "^7.7.0",
137+
"eslint": "^7.9.0",
138138
"espree": "^7.3.0",
139139
"falafel": "^2.2.4",
140140
"fs-extra": "^9.0.1",
@@ -144,7 +144,7 @@
144144
"into-stream": "^6.0.0",
145145
"jasmine-core": "^3.5.0",
146146
"jsdom": "^16.4.0",
147-
"karma": "^5.1.1",
147+
"karma": "^5.2.2",
148148
"karma-browserify": "^7.0.0",
149149
"karma-chrome-launcher": "^3.1.0",
150150
"karma-firefox-launcher": "^1.3.0",
@@ -155,7 +155,7 @@
155155
"karma-verbose-reporter": "0.0.6",
156156
"karma-viewport": "^1.0.6",
157157
"lodash": "^4.17.20",
158-
"madge": "^3.9.2",
158+
"madge": "^3.10.0",
159159
"minify-stream": "^2.1.0",
160160
"mkdirp": "^1.0.4",
161161
"node-sass": "^4.14.1",

src/components/fx/hover.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -1103,16 +1103,21 @@ function createHoverText(hoverData, opts, gd) {
11031103
hoverLabels.each(function(d) {
11041104
var g = d3.select(this).attr('transform', '');
11051105

1106+
var dColor = d.color;
1107+
if(Array.isArray(dColor)) {
1108+
dColor = dColor[d.eventData[0].pointNumber];
1109+
}
1110+
11061111
// combine possible non-opaque trace color with bgColor
1107-
var color0 = d.bgcolor || d.color;
1112+
var color0 = d.bgcolor || dColor;
11081113
// color for 'nums' part of the label
11091114
var numsColor = Color.combine(
11101115
Color.opacity(color0) ? color0 : Color.defaultLine,
11111116
bgColor
11121117
);
11131118
// color for 'name' part of the label
11141119
var nameColor = Color.combine(
1115-
Color.opacity(d.color) ? d.color : Color.defaultLine,
1120+
Color.opacity(dColor) ? dColor : Color.defaultLine,
11161121
bgColor
11171122
);
11181123
// find a contrasting color for border and text

src/components/legend/draw.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,7 @@ function computeLegendDimensions(gd, groups, traces, opts) {
708708
var w = textGap + d[0].width;
709709
var next = (oneRowLegend ? w : maxItemWidth) + itemGap;
710710

711-
if((next + bw + offsetX) > opts._maxWidth) {
711+
if((next + bw + offsetX - itemGap) >= opts._maxWidth) {
712712
maxRowWidth = Math.max(maxRowWidth, rowWidth);
713713
offsetX = 0;
714714
offsetY += maxItemHeightInRow;

0 commit comments

Comments
 (0)