Skip to content

Commit 592fc9e

Browse files
committed
🔪 unused trace._separators
1 parent d0e0158 commit 592fc9e

File tree

4 files changed

+3
-12
lines changed

4 files changed

+3
-12
lines changed

src/traces/carpet/axis_defaults.js

-2
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, options)
179179
}
180180
}
181181

182-
containerOut._separators = options.fullLayout.separators;
183-
184182
// fill in categories
185183
containerOut._initialCategories = axType === 'category' ?
186184
orderedCategories(letter, containerOut.categoryorder, containerOut.categoryarray, options.data) :

src/traces/contour/plot.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ exports.createLineClip = function(lineContainer, clipLinesForLabels, clips, uid)
421421

422422
exports.labelFormatter = function(contours, colorbar, fullLayout) {
423423
if(contours.labelformat) {
424-
return d3.format(contours.labelformat);
424+
return fullLayout._d3locale.numberFormat(contours.labelformat);
425425
}
426426
else {
427427
var formatAxis;
@@ -431,7 +431,6 @@ exports.labelFormatter = function(contours, colorbar, fullLayout) {
431431
else {
432432
formatAxis = {
433433
type: 'linear',
434-
_separators: '.,',
435434
_id: 'ycontour',
436435
nticks: (contours.end - contours.start) / contours.size,
437436
showexponent: 'all',

src/traces/contour/style_defaults.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,5 @@ module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, layout,
4646
coerce('contours.labelformat');
4747
}
4848

49-
if(opts.hasHover !== false) {
50-
coerce('zhoverformat');
51-
// Needed for formatting of hoverlabel if format is not explicitly specified
52-
traceOut._separators = layout.separators;
53-
}
49+
if(opts.hasHover !== false) coerce('zhoverformat');
5450
};

src/traces/heatmap/style_defaults.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
'use strict';
1111

12-
module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, layout) {
12+
module.exports = function handleStyleDefaults(traceIn, traceOut, coerce) {
1313
var zsmooth = coerce('zsmooth');
1414
if(zsmooth === false) {
1515
// ensure that xgap and ygap are coerced only when zsmooth allows them to have an effect.
@@ -18,6 +18,4 @@ module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, layout)
1818
}
1919

2020
coerce('zhoverformat');
21-
// Needed for formatting of hoverlabel if format is not explicitly specified
22-
traceOut._separators = layout.separators;
2321
};

0 commit comments

Comments
 (0)