Skip to content

Commit 4e0490f

Browse files
committed
update histogram supplyDefaults test because it's not doing as much
1 parent 128115b commit 4e0490f

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

test/jasmine/tests/histogram_test.js

+9-6
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,10 @@ describe('Test histogram', function() {
8484

8585
});
8686

87-
it('should set autobinx to false if xbins is supplied and true if not', function() {
87+
// coercing bin attributes got moved to calc because it needs
88+
// axis type - so here we just test that it's NOT happening
89+
90+
it('should not coerce autobinx regardless of xbins', function() {
8891
traceIn = {
8992
x: [1, 2, 2],
9093
xbins: {
@@ -94,16 +97,16 @@ describe('Test histogram', function() {
9497
}
9598
};
9699
supplyDefaults(traceIn, traceOut);
97-
expect(traceOut.autobinx).toBe(false);
100+
expect(traceOut.autobinx).toBeUndefined();
98101

99102
traceIn = {
100103
x: [1, 2, 2]
101104
};
102105
supplyDefaults(traceIn, traceOut);
103-
expect(traceOut.autobinx).toBe(true);
106+
expect(traceOut.autobinx).toBeUndefined();
104107
});
105108

106-
it('should set autobiny to false if ybins is supplied and true if not', function() {
109+
it('should not coerce autobiny regardless of ybins', function() {
107110
traceIn = {
108111
y: [1, 2, 2],
109112
ybins: {
@@ -113,13 +116,13 @@ describe('Test histogram', function() {
113116
}
114117
};
115118
supplyDefaults(traceIn, traceOut);
116-
expect(traceOut.autobiny).toBe(false);
119+
expect(traceOut.autobiny).toBeUndefined();
117120

118121
traceIn = {
119122
y: [1, 2, 2]
120123
};
121124
supplyDefaults(traceIn, traceOut);
122-
expect(traceOut.autobiny).toBe(true);
125+
expect(traceOut.autobiny).toBeUndefined();
123126
});
124127

125128
});

0 commit comments

Comments
 (0)