Skip to content

Commit 4c4828a

Browse files
committed
drop pattern from funnel marker
1 parent fc1adf5 commit 4c4828a

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

src/traces/funnel/attributes.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ var hovertemplateAttrs = require('../../plots/template_attributes').hovertemplat
77
var texttemplateAttrs = require('../../plots/template_attributes').texttemplateAttrs;
88
var constants = require('./constants');
99
var extendFlat = require('../../lib/extend').extendFlat;
10+
var extendDeep = require('../../lib/extend').extendDeep;
1011
var Color = require('../../components/color');
1112

1213
module.exports = {
@@ -75,7 +76,7 @@ module.exports = {
7576
offset: extendFlat({}, barAttrs.offset, {arrayOk: false}),
7677
width: extendFlat({}, barAttrs.width, {arrayOk: false}),
7778

78-
marker: barAttrs.marker,
79+
marker: funnelMarker(),
7980

8081
connector: {
8182
fillcolor: {
@@ -108,3 +109,9 @@ module.exports = {
108109
offsetgroup: barAttrs.offsetgroup,
109110
alignmentgroup: barAttrs.alignmentgroup
110111
};
112+
113+
function funnelMarker() {
114+
var marker = extendDeep({}, barAttrs.marker);
115+
delete marker.pattern;
116+
return marker;
117+
}

src/traces/funnel/defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
4848
var markerColor = coerce('marker.color', defaultColor);
4949
coerce('marker.line.color', Color.defaultLine);
5050
coerce('marker.line.width');
51-
Lib.coercePattern(coerce, 'marker.pattern');
5251

5352
var connectorVisible = coerce('connector.visible');
5453
if(connectorVisible) {

src/traces/funnel/style.js

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ function style(gd, cd, sel) {
3131
}
3232
});
3333

34-
Drawing.pointStyle(gTrace.selectAll('path'), trace, gd);
3534
styleTextPoints(gTrace, trace, gd);
3635

3736
gTrace.selectAll('.regions').each(function() {

test/image/baselines/pattern_bars.png

-76 Bytes
Loading

0 commit comments

Comments
 (0)