Skip to content

Commit 4975417

Browse files
committed
#30a PR feedback: commenting and removing disused binding
1 parent e02a3f6 commit 4975417

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/components/modebar/buttons.js

+2
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,8 @@ function handleCamera3d(gd, ev) {
350350

351351
if(attr === 'resetDefault') scene.setCameraToDefault();
352352
else if(attr === 'resetLastSave') {
353+
// This handler looks in the un-updated fullLayout.scene.camera object to reset the camera
354+
// to the last saved position.
353355
scene.setCamera(fullSceneLayout.camera);
354356
}
355357
}

test/jasmine/tests/gl_plot_interact_test.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -214,14 +214,13 @@ describe('Test gl plot interactions', function() {
214214
describe('gl3d plots', function() {
215215

216216
var mock = require('@mocks/gl3d_scatter3d-connectgaps.json'),
217-
modeBar, relayoutCallback;
217+
relayoutCallback;
218218

219219
beforeEach(function(done) {
220220
gd = createGraphDiv();
221221

222222
Plotly.plot(gd, mock.data, mock.layout).then(function() {
223223

224-
modeBar = gd._fullLayout._modeBar;
225224
relayoutCallback = jasmine.createSpy('relayoutCallback');
226225

227226
gd.on('plotly_relayout', relayoutCallback);

0 commit comments

Comments
 (0)