Merge pull request #873 from plotly/fix-range-selector-overlaying

etpinard · web-flow · commit 482fb09a412a · 2016-08-22T14:02:09.000-04:00
Fix range selector position logic for overlaying axes
diff --git a/src/components/rangeselector/defaults.js b/src/components/rangeselector/defaults.js
@@ -83,7 +83,8 @@ function getPosDflt(containerOut, layout, counterAxes) {
 
     var posY = 0;
     for(var i = 0; i < anchoredList.length; i++) {
-        posY = Math.max(layout[anchoredList[i]].domain[1], posY);
+        var domain = layout[anchoredList[i]].domain;
+        if(domain) posY = Math.max(domain[1], posY);
     }
 
     return [containerOut.domain[0], posY + constants.yPad];
diff --git a/test/jasmine/tests/range_selector_test.js b/test/jasmine/tests/range_selector_test.js
@@ -161,7 +161,7 @@ describe('range selector defaults:', function() {
             },
             yaxis2: {
                 anchor: 'x',
-                domain: [0.3, 0.55]
+                overlaying: 'y'
             },
             yaxis3: {
                 anchor: 'x',

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,8 @@ function getPosDflt(containerOut, layout, counterAxes) {`
`83`	`83`
`84`	`84`	`var posY = 0;`
`85`	`85`	`for(var i = 0; i < anchoredList.length; i++) {`
`86`		`- posY = Math.max(layout[anchoredList[i]].domain[1], posY);`
	`86`	`+ var domain = layout[anchoredList[i]].domain;`
	`87`	`+ if(domain) posY = Math.max(domain[1], posY);`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`return [containerOut.domain[0], posY + constants.yPad];`