Skip to content

Commit 474891d

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md
1 parent f043b7b commit 474891d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ Thanks for your interest in plotly.js!
22

33
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
44

5-
Developers should `git rebase` their local branch off the latest `master` before opening a pull request.
5+
Before opening a pull request, developer should:
6+
7+
- `git rebase` their local branch off the latest `master`
8+
- make sure to **not** `git add` the `dist/` folder (the `dist/` is updated only on verion bumps)
9+
- write an overview of what the PR attempts to do.
610

711
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please `git merge master` into your PR branch instead of `git rebase master`.

0 commit comments

Comments
 (0)