You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+5-1
Original file line number
Diff line number
Diff line change
@@ -2,6 +2,10 @@ Thanks for your interest in plotly.js!
2
2
3
3
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
4
4
5
-
Developers should `git rebase` their local branch off the latest `master` before opening a pull request.
5
+
Before opening a pull request, developer should:
6
+
7
+
-`git rebase` their local branch off the latest `master`
8
+
- make sure to **not**`git add` the `dist/` folder (the `dist/` is updated only on verion bumps)
9
+
- write an overview of what the PR attempts to do.
6
10
7
11
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please `git merge master` into your PR branch instead of `git rebase master`.
0 commit comments