Skip to content

Commit 46bc623

Browse files
committed
clean up export names for scattergl/convert.js
1 parent 55906cc commit 46bc623

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

src/traces/scattergl/convert.js

+7-5
Original file line numberDiff line numberDiff line change
@@ -565,9 +565,11 @@ function convertErrorBarPositions(gd, trace, positions, x, y) {
565565
}
566566

567567
module.exports = {
568-
convertStyle: convertStyle,
569-
convertMarkerStyle: convertMarkerStyle,
570-
convertMarkerSelection: convertMarkerSelection,
571-
convertLinePositions: convertLinePositions,
572-
convertErrorBarPositions: convertErrorBarPositions
568+
style: convertStyle,
569+
570+
markerStyle: convertMarkerStyle,
571+
markerSelection: convertMarkerSelection,
572+
573+
linePositions: convertLinePositions,
574+
errorBarPositions: convertErrorBarPositions,
573575
};

src/traces/scattergl/index.js

+7-11
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,7 @@ var calcColorscales = require('../scatter/colorscale_calc');
2727
var linkTraces = require('../scatter/link_traces');
2828
var getTraceColor = require('../scatter/get_trace_color');
2929
var fillHoverText = require('../scatter/fill_hover_text');
30-
31-
var convertStyle = require('./convert').convertStyle;
32-
var convertLinePositions = require('./convert').convertLinePositions;
33-
var convertErrorBarPositions = require('./convert').convertErrorBarPositions;
30+
var convert = require('./convert');
3431

3532
var BADNUM = require('../../constants/numerical').BADNUM;
3633
var TOO_MANY_POINTS = require('./constants').TOO_MANY_POINTS;
@@ -138,7 +135,7 @@ function calc(gd, trace) {
138135

139136
// create scene options
140137
function sceneOptions(gd, subplot, trace, positions, x, y) {
141-
var opts = convertStyle(gd, trace);
138+
var opts = convert.style(gd, trace);
142139

143140
if(opts.marker) {
144141
opts.marker.positions = positions;
@@ -147,12 +144,12 @@ function sceneOptions(gd, subplot, trace, positions, x, y) {
147144
if(opts.line && positions.length > 1) {
148145
Lib.extendFlat(
149146
opts.line,
150-
convertLinePositions(gd, trace, positions)
147+
convert.linePositions(gd, trace, positions)
151148
);
152149
}
153150

154151
if(opts.errorX || opts.errorY) {
155-
var errors = convertErrorBarPositions(gd, trace, positions, x, y);
152+
var errors = convert.errorBarPositions(gd, trace, positions, x, y);
156153

157154
if(opts.errorX) {
158155
Lib.extendFlat(opts.errorX, errors.x);
@@ -568,10 +565,9 @@ function plot(gd, subplot, cdata) {
568565
stash.xpx = stash.ypx = null;
569566
}
570567

571-
return trace.visible ? {
572-
viewport: viewport,
573-
range: range
574-
} : null;
568+
return trace.visible ?
569+
{viewport: viewport, range: range} :
570+
null;
575571
});
576572

577573
if(selectMode) {

src/traces/splom/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ var subTypes = require('../scatter/subtypes');
2020
var calcMarkerSize = require('../scatter/calc').calcMarkerSize;
2121
var calcAxisExpansion = require('../scatter/calc').calcAxisExpansion;
2222
var calcColorscales = require('../scatter/colorscale_calc');
23-
var convertMarkerSelection = require('../scattergl/convert').convertMarkerSelection;
24-
var convertMarkerStyle = require('../scattergl/convert').convertMarkerStyle;
23+
var convertMarkerSelection = require('../scattergl/convert').markerSelection;
24+
var convertMarkerStyle = require('../scattergl/convert').markerStyle;
2525
var calcHover = require('../scattergl').calcHover;
2626

2727
var BADNUM = require('../../constants/numerical').BADNUM;

0 commit comments

Comments
 (0)