Skip to content

Commit 4679800

Browse files
committed
sort list of scatter3d dash and symbols for schema
1 parent 08e3f57 commit 4679800

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/traces/scatter3d/attributes.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ var DASHES = require('../../constants/gl3d_dashes');
1111
var MARKER_SYMBOLS = require('../../constants/gl3d_markers');
1212
var extendFlat = require('../../lib/extend').extendFlat;
1313
var overrideAll = require('../../plot_api/edit_types').overrideAll;
14+
var sortedObjectKeys = require('../../lib/sorted_object_keys');
1415

1516
var scatterLineAttrs = scatterAttrs.line;
1617
var scatterMarkerAttrs = scatterAttrs.marker;
@@ -20,7 +21,7 @@ var lineAttrs = extendFlat({
2021
width: scatterLineAttrs.width,
2122
dash: {
2223
valType: 'enumerated',
23-
values: Object.keys(DASHES),
24+
values: sortedObjectKeys(DASHES),
2425
dflt: 'solid',
2526
description: 'Sets the dash style of the lines.'
2627
}
@@ -122,7 +123,7 @@ var attrs = module.exports = overrideAll({
122123
marker: extendFlat({ // Parity with scatter.js?
123124
symbol: {
124125
valType: 'enumerated',
125-
values: Object.keys(MARKER_SYMBOLS),
126+
values: sortedObjectKeys(MARKER_SYMBOLS),
126127
dflt: 'circle',
127128
arrayOk: true,
128129
description: 'Sets the marker symbol type.'

test/plot-schema.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44079,12 +44079,12 @@
4407944079
"editType": "calc",
4408044080
"valType": "enumerated",
4408144081
"values": [
44082-
"solid",
44083-
"dot",
4408444082
"dash",
44085-
"longdash",
4408644083
"dashdot",
44087-
"longdashdot"
44084+
"dot",
44085+
"longdash",
44086+
"longdashdot",
44087+
"solid"
4408844088
]
4408944089
},
4409044090
"editType": "calc",
@@ -44796,11 +44796,11 @@
4479644796
"values": [
4479744797
"circle",
4479844798
"circle-open",
44799-
"square",
44800-
"square-open",
44799+
"cross",
4480144800
"diamond",
4480244801
"diamond-open",
44803-
"cross",
44802+
"square",
44803+
"square-open",
4480444804
"x"
4480544805
]
4480644806
},

0 commit comments

Comments
 (0)