Skip to content

Commit 428096e

Browse files
committed
restrict labelalias to be plain object and hasOwnProperty
1 parent c83ac53 commit 428096e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/plots/cartesian/axes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1660,7 +1660,7 @@ axes.tickText = function(ax, x, hover, noSuffixPrefix) {
16601660
if(ax.ticksuffix && !isHidden(ax.showticksuffix)) out.text += ax.ticksuffix;
16611661
}
16621662

1663-
if(ax.labelalias) {
1663+
if(ax.labelalias && ax.labelalias.hasOwnProperty(out.text)) {
16641664
var t = ax.labelalias[out.text];
16651665
if(typeof t === 'string') out.text = t;
16661666
}

src/plots/cartesian/tick_label_defaults.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ var handleArrayContainerDefaults = require('../array_container_defaults');
99
module.exports = function handleTickLabelDefaults(containerIn, containerOut, coerce, axType, options) {
1010
if(!options) options = {};
1111

12-
coerce('labelalias');
12+
var labelalias = coerce('labelalias');
13+
if(!Lib.isPlainObject(labelalias)) delete containerOut.labelalias;
1314

1415
var showAttrDflt = getShowAttrDflt(containerIn);
1516

0 commit comments

Comments
 (0)