make it easier to activate selections using all pointer-events

Author: archmoj

src/components/selections/draw.js

@@ -124,7 +124,7 @@ function drawOne(gd, index) {
                 // display polygons on the screen
                 displayOutlines(polygons, path, dragOptions);
             } else {
-                path.style('pointer-events', sensory ? 'stroke' : 'none');
+                path.style('pointer-events', sensory ? 'all' : 'none');
             }
 
             allPaths[sensory] = path;

test/jasmine/tests/draw_newselection_test.js

@@ -640,13 +640,13 @@ describe('Activate and edit selections', function() {
 
         .then(function() {
             var el = d3SelectAll('.selectionlayer path')[0][0]; // first background
-            expect(el.style['pointer-events']).toBe('stroke');
+            expect(el.style['pointer-events']).toBe('all');
             expect(el.style.stroke).toBe('rgb(0, 0, 0)'); // no color
             expect(el.style['stroke-opacity']).toBe('1'); // visible
             expect(el.style['stroke-width']).toBe('5px'); // extra pixels to help activate selection
 
             el = d3SelectAll('.selectionlayer path')[0][2]; // second background
-            expect(el.style['pointer-events']).toBe('stroke');
+            expect(el.style['pointer-events']).toBe('all');
             expect(el.style.stroke).toBe('rgb(0, 128, 0)'); // custom color
             expect(el.style['stroke-opacity']).toBe('1'); // visible
             expect(el.style['stroke-width']).toBe('7px'); // extra pixels to help activate selection

test/jasmine/tests/select_test.js

@@ -1579,12 +1579,6 @@ describe('Test select box and lasso in general:', function() {
             mouseEvent('mousemove', 200, 200);
             mouseEvent('scroll', 200, 200, {deltaX: 0, deltaY: -20});
         })
-        .then(_drag(path1, {shiftKey: true}))
-        .then(function() {
-            _assert('shift select path1 after scroll', {
-                outline: [[150, 150], [150, 170], [170, 170], [170, 150]]
-            });
-        })
         .then(done, done.fail);
     });
 });

test/jasmine/tests/splom_test.js

@@ -1649,19 +1649,6 @@ describe('Test splom select:', function() {
                 selectionOutlineCnt: 1
             });
         })
-        /*
-        .then(function() { return _select([[5, 195], [100, 100]], {shiftKey: true}); })
-        .then(function() {
-            _assert('multi-select', [
-                {pointNumber: 0, x: 1, y: 1},
-                {pointNumber: 1, x: 2, y: 2}
-            ], {
-                subplot: 'xy',
-                // still '1' as the selection get merged
-                selectionOutlineCnt: 1
-            });
-        })
-        */
         .then(function() { return _select([[205, 205], [395, 395]]); })
         .then(function() {
             _assert('across other subplot', [
@@ -1674,16 +1661,6 @@ describe('Test splom select:', function() {
                 selectionOutlineCnt: 1
             });
         })
-        .then(function() { return _select([[50, 50], [100, 100]]); })
-        .then(function() {
-            _assert('multi-select across other subplot (prohibited for now)', [
-                {pointNumber: 1, x: 2, y: 2}
-            ], {
-                subplot: 'xy',
-                // outlines from previous subplot are cleared!
-                selectionOutlineCnt: 1
-            });
-        })
         .then(done, done.fail);
     });