Skip to content

Commit 40fb223

Browse files
committed
sankey: call _guiRestyle via Registry + slight code simplification
1 parent 8ddfe7e commit 40fb223

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/traces/sankey/render.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var repeat = gup.repeat;
2323
var unwrap = gup.unwrap;
2424
var interpolateNumber = require('d3-interpolate').interpolateNumber;
2525

26-
var Plotly = require('../../plot_api/plot_api');
26+
var Registry = require('../../registry');
2727

2828
// view models
2929

@@ -233,7 +233,7 @@ function sankeyModel(layout, d, traceIndex) {
233233
}
234234

235235
// Force node position
236-
if(trace.node.x.length !== 0 && trace.node.y.length !== 0) {
236+
if(trace.node.x.length && trace.node.y.length) {
237237
for(i = 0; i < Math.min(trace.node.x.length, trace.node.y.length, graph.nodes.length); i++) {
238238
if(trace.node.x[i] && trace.node.y[i]) {
239239
var pos = [trace.node.x[i] * width, trace.node.y[i] * height];
@@ -663,6 +663,7 @@ function attachDragHandler(sankeyNode, sankeyLink, callbacks, gd) {
663663
})
664664

665665
.on('dragend', function(d) {
666+
if(d.arrangement === 'fixed') return;
666667
d.interactionState.dragInProgress = false;
667668
for(var i = 0; i < d.node.childrenNodes.length; i++) {
668669
d.node.childrenNodes[i].x = d.node.x;
@@ -751,7 +752,7 @@ function persistFinalNodePositions(d, gd) {
751752
x.push(nodeX / d.figure.width);
752753
y.push(nodeY / d.figure.height);
753754
}
754-
Plotly._guiRestyle(gd, {
755+
Registry.call('_guiRestyle', gd, {
755756
'node.x': [x],
756757
'node.y': [y]
757758
}, d.trace.index)
@@ -814,7 +815,7 @@ module.exports = function(gd, svg, calcData, layout, callbacks) {
814815
});
815816

816817
// To prevent animation on dragging
817-
var dragcover = gd.querySelector('.dragcover');
818+
var dragcover = gd._fullLayout._dragCover;
818819

819820
var styledData = calcData
820821
.filter(function(d) {return unwrap(d).trace.visible;})

0 commit comments

Comments
 (0)