expose the tickformat attribute

Author: monfera

src/traces/parcoords/attributes.js

@@ -56,6 +56,16 @@ module.exports = {
         },
         tickvals: axesAttrs.tickvals,
         ticktext: axesAttrs.ticktext,
+        tickformat: {
+            valType: 'string',
+            dflt: '3s',
+            role: 'style',
+            description: [
+                'Sets the tick label formatting rule using d3 formatting mini-language',
+                'which is similar to those of Python. See',
+                'https://github.com/d3/d3-format/blob/master/README.md#locale_format'
+            ].join(' ')
+        },
         visible: {
             valType: 'boolean',
             dflt: true,

src/traces/parcoords/calc.js

@@ -23,6 +23,7 @@ module.exports = function calc(gd, trace) {
             constraintrange: inputDimensions[i].constraintrange,
             tickvals: inputDimensions[i].tickvals,
             ticktext: inputDimensions[i].ticktext,
+            tickformat: inputDimensions[i].tickformat,
             visible: inputDimensions[i].visible,
             label: inputDimensions[i].label,
             values: inputDimensions[i].values

src/traces/parcoords/constants.js

@@ -15,7 +15,6 @@ module.exports = {
     legendWidth: 80,
     verticalPadding: 2, // otherwise, horizontal lines on top or bottom are of lower width
     tickDistance: 50,
-    tickFormat: '3s',
     canvasPixelRatio: 1,
     blockLineCount: 5000,
     scatter: false,

src/traces/parcoords/defaults.js

@@ -61,6 +61,7 @@ function dimensionsDefaults(traceIn, traceOut) {
             coerce('label');
             coerce('tickvals');
             coerce('ticktext');
+            coerce('tickformat');
             coerce('range');
             coerce('constraintrange');
             coerce('values');

src/traces/parcoords/parcoords.js

@@ -184,8 +184,9 @@ function viewModel(model) {
         return {
             key: key,
             label: dimension.label,
-            tickvals: dimension.tickvals || false,
-            ticktext: dimension.ticktext || false,
+            tickFormat: dimension.tickformat,
+            tickvals: dimension.tickvals,
+            ticktext: dimension.ticktext,
             ordinal: !!dimension.tickvals,
             scatter: c.scatter || dimension.scatter,
             xIndex: i,
@@ -548,7 +549,7 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
                     .orient('left')
                     .tickSize(4)
                     .outerTickSize(2)
-                    .ticks(wantedTickCount, c.tickFormat) // works for continuous scales only...
+                    .ticks(wantedTickCount, d.tickFormat) // works for continuous scales only...
                     .tickValues(d.ordinal ? // and this works for ordinal scales
                         sdom.filter(function(d, i) {return !(i % Math.round((sdom.length / wantedTickCount)));})
                             .map(function(d, i) {return texts && texts[i] || d;}) :
@@ -619,7 +620,7 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
         .data(repeat, keyFun);
 
     function formatExtreme(d) {
-        return d.ordinal ? function() {return '';} : d3.format(c.tickFormat);
+        return d.ordinal ? function() {return '';} : d3.format(d.tickFormat);
     }
 
     axisExtentTopText.enter()

test/image/baselines/gl2d_parcoords.png

@@ -29,6 +29,7 @@
         "id": "Block width",
         "label": "Block width",
         "range": [0, 700000],
+        "tickformat": "",
         "values": [268630, 489543, 379086, 600000, 489543, 268630, 600000, 379086, 268630, 489543, 379086, 600000, 489543, 268630, 600000, 379086, 268630, 489543, 379086, 600000, 489543, 268630, 600000, 379086, 268630, 489543, 436900, 373600, 268630, 439000, 381800, 491200, 402800, 381400, 485600, 600000, 372200, 394700, 383800, 401100, 356500, 313200, 487100, 490700, 432299, 530300, 521500, 456700, 333800, 343200, 394000, 328200, 487700, 383600, 317700, 324600, 482900, 515100, 500100, 562700, 486000, 453400, 352900, 331300, 496200, 469099, 472500, 354700, 507700, 509000, 439300, 525300, 347600, 379000, 432800, 378800, 383200, 523800, 600000, 313600, 497700, 411300, 420000, 381100, 342800, 385900, 268630, 495800, 488000, 446400, 397900, 373300, 385700, 396500, 475700, 510600, 586800, 596000, 407600, 439200]
       },
       {

test/image/mocks/gl2d_parcoords.json

@@ -82,7 +82,7 @@ describe('parcoords initialization tests', function() {
                     alienProperty: 'Alpha Centauri'
                 }]
             });
-            expect(fullTrace.dimensions).toEqual([{values: [1], visible: true, _index: 0}]);
+            expect(fullTrace.dimensions).toEqual([{values: [1], visible: true, tickformat: '3s', _index: 0}]);
         });
 
         it('\'dimension.visible\' should be set to false, and other props just passed through if \'values\' is not provided', function() {
@@ -125,8 +125,8 @@ describe('parcoords initialization tests', function() {
                 {values: [1, 2], visible: false} // shouldn't be truncated to as false
             ]});
             expect(fullTrace.dimensions).toEqual([
-                {values: [321, 534, 542], visible: true, _index: 0},
-                {values: [562, 124, 942], visible: true, _index: 1},
+                {values: [321, 534, 542], visible: true, tickformat: '3s', _index: 0},
+                {values: [562, 124, 942], visible: true, tickformat: '3s', _index: 1},
                 {values: [], visible: false},
                 {values: [1, 2], visible: false}
             ]);
@@ -587,6 +587,7 @@ describe('parcoords', function() {
             restyleDimension('label', 'new label')()
                 .then(restyleDimension('tickvals', [[0, 0.1, 0.4, 1, 2]]))
                 .then(restyleDimension('ticktext', [['alpha', 'gamma', 'beta', 'omega', 'epsilon']]))
+                .then(restyleDimension('tickformat', '4s'))
                 .then(restyleDimension('range', [[0, 2]]))
                 .then(restyleDimension('constraintrange', [[0, 1]]))
                 .then(restyleDimension('values', [[0, 0.1, 0.4, 1, 2, 0, 0.1, 0.4, 1, 2]]))