Skip to content

Commit 3e250df

Browse files
committed
tweak docs & remove commented-out code
1 parent 7279b55 commit 3e250df

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

src/plots/plots.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -265,9 +265,9 @@ var extraFormatKeys = [
265265
* trace into the new one. Use skipUpdateCalc to defer this (needed by Plotly.react)
266266
*
267267
* gd.data, gd.layout:
268-
* are precisely what the user specified,
269-
* these fields shouldn't be modified nor used directly
270-
* after the supply defaults step.
268+
* are precisely what the user specified (except as modified by cleanData/cleanLayout),
269+
* these fields shouldn't be modified (except for filling in some auto values)
270+
* nor used directly after the supply defaults step.
271271
*
272272
* gd._fullData, gd._fullLayout:
273273
* are complete descriptions of how to draw the plot,

src/traces/contourcarpet/attributes.js

-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ module.exports = extendFlat({}, {
4040
atype: heatmapAttrs.xtype,
4141
btype: heatmapAttrs.ytype,
4242

43-
// unimplemented - looks like connectgaps is implied true
44-
// connectgaps: heatmapAttrs.connectgaps,
45-
4643
fillcolor: contourAttrs.fillcolor,
4744

4845
autocontour: contourAttrs.autocontour,

src/traces/contourcarpet/defaults.js

-3
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
5555
coerce('text');
5656
var isConstraint = (coerce('contours.type') === 'constraint');
5757

58-
// Unimplemented:
59-
// coerce('connectgaps', Lib.isArray1D(traceOut.z));
60-
6158
// trace-level showlegend has already been set, but is only allowed if this is a constraint
6259
if(!isConstraint) delete traceOut.showlegend;
6360

0 commit comments

Comments
 (0)