Skip to content

Commit 3de5a73

Browse files
committed
axis ticks - tickvals, ticktext (no more 'integer')
(cherry picked from commit 5dc10f8)
1 parent 92a42ba commit 3de5a73

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/traces/parcoords/parcoords.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function domainScale(height, padding, dimension) {
8585
function unitScale(height, padding) {return d3.scale.linear().range([height - padding, padding]);}
8686
function domainToUnitScale(dimension) {return d3.scale.linear().domain(dimensionExtent(dimension));}
8787

88-
function integerScale(dimension) {
88+
function ordinalScale(dimension) {
8989
var extent = dimensionExtent(dimension);
9090
return dimension.tickvals && d3.scale.ordinal()
9191
.domain(dimension.tickvals)
@@ -151,7 +151,7 @@ function viewModel(model) {
151151
key: dimension.id || dimension.label,
152152
label: dimension.label,
153153
tickvals: dimension.tickvals || false,
154-
integer: !!dimension.tickvals,
154+
ordinal: !!dimension.tickvals,
155155
scatter: dimension.scatter,
156156
xIndex: i,
157157
originalXIndex: i,
@@ -163,7 +163,7 @@ function viewModel(model) {
163163
canvasX: xScale(i) * canvasPixelRatio,
164164
unitScale: unitScale(height, verticalPadding),
165165
domainScale: domainScale(height, verticalPadding, dimension),
166-
integerScale: integerScale(dimension),
166+
ordinalScale: ordinalScale(dimension),
167167
domainToUnitScale: domainToUnit,
168168
pieChartCheat: dimension.pieChartCheat,
169169
filter: dimension.constraintrange ? dimension.constraintrange.map(domainToUnit) : [0, 1],
@@ -385,7 +385,7 @@ module.exports = function(root, styledData, layout, callbacks) {
385385
.tickSize(4)
386386
.outerTickSize(2)
387387
.ticks(wantedTickCount, '3s') // works for continuous scales only...
388-
.tickValues(d.integer ? // and this works for ordinal scales
388+
.tickValues(d.ordinal ? // and this works for ordinal scales
389389
dom.filter(function(d, i) {return !(i % Math.round((dom.length / wantedTickCount)));}) :
390390
null)
391391
.scale(scale));
@@ -450,7 +450,7 @@ module.exports = function(root, styledData, layout, callbacks) {
450450
.data(repeat, keyFun);
451451

452452
function formatExtreme(d) {
453-
return d.integer ? d3.format('.0s') : d3.format('.3s');
453+
return d.ordinal ? d3.format('.0s') : d3.format('.3s');
454454
}
455455

456456
axisExtentTopText.enter()
@@ -563,9 +563,9 @@ module.exports = function(root, styledData, layout, callbacks) {
563563
var empty = extent[0] === extent[1];
564564
var panels = dimension.parent.panels;
565565
var f = panels[dimension.xIndex].filter;
566-
if(!empty && dimension.integer) {
567-
f[0] = ordinalScaleSnap(dimension.integerScale, f[0]);
568-
f[1] = ordinalScaleSnap(dimension.integerScale, f[1]);
566+
if(!empty && dimension.ordinal) {
567+
f[0] = ordinalScaleSnap(dimension.ordinalScale, f[0]);
568+
f[1] = ordinalScaleSnap(dimension.ordinalScale, f[1]);
569569
if(f[0] === f[1]) {
570570
f[0] = Math.max(0, f[0] - 0.05);
571571
f[1] = Math.min(1, f[1] + 0.05);

0 commit comments

Comments
 (0)