Skip to content

Commit 3c3fda4

Browse files
committed
🎎 for Lib.mergeArray vs Lib.fillArray
1 parent d7999e2 commit 3c3fda4

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

src/lib/index.js

+13-1
Original file line numberDiff line numberDiff line change
@@ -350,14 +350,26 @@ lib.noneOrAll = function(containerIn, containerOut, attrList) {
350350
}
351351
};
352352

353+
/** merges calcdata field (given by cdAttr) with traceAttr values
354+
*
355+
* N.B. Loop over minimum of cd.length and traceAttr.length
356+
* i.e. it does not try to fill in beyond traceAttr.length-1
357+
*
358+
* @param {array} traceAttr : trace attribute
359+
* @param {object} cd : calcdata trace
360+
* @param {string} cdAttr : calcdata key
361+
*/
353362
lib.mergeArray = function(traceAttr, cd, cdAttr) {
354363
if(Array.isArray(traceAttr)) {
355364
var imax = Math.min(traceAttr.length, cd.length);
356365
for(var i = 0; i < imax; i++) cd[i][cdAttr] = traceAttr[i];
357366
}
358367
};
359368

360-
/** fill data array into calcdata items
369+
/** fills calcdata field (given by cdAttr) with traceAttr values
370+
* or function of traceAttr values (e.g. some fallback)
371+
*
372+
* N.B. Loops over all of cd item.
361373
*
362374
* @param {array} traceAttr : trace attribute
363375
* @param {object} cd : calcdata trace

0 commit comments

Comments
 (0)