update non-finance tests for finance refactor

Author: alexcjohnson

test/jasmine/tests/axes_test.js

@@ -183,7 +183,8 @@ describe('Test axes', function() {
                 _has: Plots._hasPlotType,
                 _basePlotModules: [],
                 _dfltTitle: {x: 'x', y: 'y'},
-                _subplots: {cartesian: ['xy'], xaxis: ['x'], yaxis: ['y']}
+                _subplots: {cartesian: ['xy'], xaxis: ['x'], yaxis: ['y']},
+                _requestRangeslider: {}
             };
             fullData = [];
         });

test/jasmine/tests/box_test.js

@@ -172,7 +172,7 @@ describe('Test box hover:', function() {
 
         return Plotly.plot(gd, fig).then(function() {
             mouseEvent('mousemove', pos[0], pos[1]);
-            assertHoverLabelContent(specs);
+            assertHoverLabelContent(specs, specs.desc);
         });
     }
 

test/jasmine/tests/plot_api_test.js

@@ -2963,10 +2963,7 @@ describe('Test plot api', function() {
                     return Plotly.react(gd, mock);
                 })
                 .then(function() {
-                    // TODO: remove this exemption once we fix finance
-                    if(mockSpec[0] !== 'finance_style') {
-                        expect(fullJson()).toEqual(initialJson);
-                    }
+                    expect(fullJson()).toEqual(initialJson);
                     countCalls({});
                 })
                 .catch(failTest)

test/jasmine/tests/range_slider_test.js

@@ -1,6 +1,7 @@
 var Plotly = require('@lib/index');
 var Lib = require('@src/lib');
 var setConvert = require('@src/plots/cartesian/set_convert');
+var name2id = require('@src/plots/cartesian/axis_ids').name2id;
 
 var RangeSlider = require('@src/components/rangeslider');
 var constants = require('@src/components/rangeslider/constants');
@@ -509,7 +510,11 @@ describe('Rangeslider handleDefaults function', function() {
 
     function _supply(layoutIn, layoutOut, axName) {
         setConvert(layoutOut[axName]);
+        layoutOut[axName]._id = name2id(axName);
+        if(!layoutOut._requestRangeslider) layoutOut._requestRangeslider = {};
         RangeSlider.handleDefaults(layoutIn, layoutOut, axName);
+        // we don't care about this after it's done its job
+        delete layoutOut._requestRangeslider;
     }
 
     it('should not coerce anything if rangeslider isn\'t set', function() {
@@ -519,6 +524,7 @@ describe('Rangeslider handleDefaults function', function() {
 
         _supply(layoutIn, layoutOut, 'xaxis');
         expect(layoutIn).toEqual(expected);
+        expect(layoutOut.xaxis.rangeslider).toBeUndefined();
     });
 
     it('should not mutate layoutIn', function() {
@@ -547,6 +553,27 @@ describe('Rangeslider handleDefaults function', function() {
         expect(layoutOut.xaxis.rangeslider).toEqual(expected);
     });
 
+    it('should set defaults if rangeslider is requested', function() {
+        var layoutIn = { xaxis: {}},
+            layoutOut = { xaxis: {}, _requestRangeslider: {x: true} },
+            expected = {
+                visible: true,
+                autorange: true,
+                thickness: 0.15,
+                bgcolor: '#fff',
+                borderwidth: 0,
+                bordercolor: '#444',
+                _input: {}
+            };
+
+        _supply(layoutIn, layoutOut, 'xaxis');
+        // in fact we DO mutate layoutIn - which we should probably try not to do,
+        // but that's a problem for another time.
+        // see https://github.com/plotly/plotly.js/issues/1473
+        expect(layoutIn).toEqual({xaxis: {rangeslider: {}}});
+        expect(layoutOut.xaxis.rangeslider).toEqual(expected);
+    });
+
     it('should set defaults if rangeslider.visible is true', function() {
         var layoutIn = { xaxis: { rangeslider: { visible: true }} },
             layoutOut = { xaxis: { rangeslider: {}} },