Merge pull request #5673 from plotly/parcoords-constraintrange-valtype

archmoj · web-flow · commit 3725a4739f0c · 2021-07-17T16:37:10.000-04:00
Fixup parcoords constraintrange valType and validate parcoords mocks
diff --git a/draftlogs/5673_change.md b/draftlogs/5673_change.md
@@ -0,0 +1,2 @@
+ - Relax the valType of `constraintrange` in `parcoords` trace [[#5673](https://github.com/plotly/plotly.js/pull/5673)]
+
diff --git a/src/traces/parcoords/attributes.js b/src/traces/parcoords/attributes.js
@@ -96,8 +96,8 @@ module.exports = {
             freeLength: true,
             dimensions: '1-2',
             items: [
-                {valType: 'number', editType: 'plot'},
-                {valType: 'number', editType: 'plot'}
+                {valType: 'any', editType: 'plot'},
+                {valType: 'any', editType: 'plot'}
             ],
             editType: 'plot',
             description: [
diff --git a/tasks/test_mock.js b/tasks/test_mock.js
@@ -162,12 +162,6 @@ function notBlackListed(name) {
         'gl2d_fonts',
         'gl2d_layout_image',
         'gl2d_marker_coloraxis',
-        'gl2d_parcoords_256_colors',
-        'gl2d_parcoords_constraints',
-        'gl2d_parcoords_out-of-range_selected-above-below',
-        'gl2d_parcoords_out-of-range_selected-all',
-        'gl2d_parcoords_out-of-range_selected-below',
-        'gl2d_parcoords_select_first_last_enum',
         'gl2d_pointcloud-basic',
         'gl2d_rgb_dont_accept_alpha_scattergl',
         'gl2d_scatter-marker-line-colorscales',
diff --git a/test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json b/test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json
@@ -19,10 +19,8 @@
                 {
                     "label": "A",
                     "constraintrange": [
-                        [
-                            2.5,
-                            10
-                        ]
+                        2.5,
+                        10
                     ],
                     "values": [
                         1,
diff --git a/test/plot-schema.json b/test/plot-schema.json
@@ -37824,11 +37824,11 @@
         "items": [
          {
           "editType": "plot",
-          "valType": "number"
+          "valType": "any"
          },
          {
           "editType": "plot",
-          "valType": "number"
+          "valType": "any"
          }
         ],
         "valType": "info_array"

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+ - Relax the valType of `constraintrange` in `parcoords` trace [[#5673](https://github.com/plotly/plotly.js/pull/5673)]
	`2`	`+`
Original file line number	Diff line number	Diff line change
`@@ -37824,11 +37824,11 @@`
`37824`	`37824`	`"items": [`
`37825`	`37825`	`{`
`37826`	`37826`	`"editType": "plot",`
`37827`		`- "valType": "number"`
	`37827`	`+ "valType": "any"`
`37828`	`37828`	`},`
`37829`	`37829`	`{`
`37830`	`37830`	`"editType": "plot",`
`37831`		`- "valType": "number"`
	`37831`	`+ "valType": "any"`
`37832`	`37832`	`}`
`37833`	`37833`	`],`
`37834`	`37834`	`"valType": "info_array"`