Skip to content

Commit 349ef64

Browse files
committed
Also fix violin traces
1 parent 1e4aa7e commit 349ef64

File tree

4 files changed

+102
-7
lines changed

4 files changed

+102
-7
lines changed

src/traces/scatter/line_points.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ module.exports = function linePoints(d, opts) {
6767
function getPt(index) {
6868
var di = d[index];
6969
if(!di) return false;
70-
var x = xa.c2p(di.x);
71-
var y = ya.c2p(di.y);
70+
var x = opts.linearized ? xa.l2p(di.x) : xa.c2p(di.x);
71+
var y = opts.linearized ? ya.l2p(di.y) : ya.c2p(di.y);
7272

7373
// if non-positive log values, set them VERY far off-screen
7474
// so the line looks essentially straight from the previous point.

src/traces/violin/plot.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) {
2828
connectGaps: true,
2929
baseTolerance: 0.75,
3030
shape: 'spline',
31-
simplify: true
31+
simplify: true,
32+
linearized: true
3233
});
3334
return Drawing.smoothopen(segments[0], 1);
3435
}
@@ -64,8 +65,8 @@ module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) {
6465
var pathSel = d3.select(this);
6566
var density = d.density;
6667
var len = density.length;
67-
var posCenter = d.pos + bPos;
68-
var posCenterPx = posAxis.c2p(posCenter);
68+
var posCenter = posAxis.c2l(d.pos + bPos, true);
69+
var posCenterPx = posAxis.l2p(posCenter);
6970

7071
var scale;
7172
if(trace.width) {
@@ -85,7 +86,7 @@ module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) {
8586
for(i = 0; i < len; i++) {
8687
pt = pts[i] = {};
8788
pt[t.posLetter] = posCenter + (density[i].v / scale);
88-
pt[t.valLetter] = density[i].t;
89+
pt[t.valLetter] = valAxis.c2l(density[i].t, true);
8990
}
9091
pathPos = makePath(pts);
9192
}
@@ -95,7 +96,7 @@ module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) {
9596
for(k = 0, i = len - 1; k < len; k++, i--) {
9697
pt = pts[k] = {};
9798
pt[t.posLetter] = posCenter - (density[i].v / scale);
98-
pt[t.valLetter] = density[i].t;
99+
pt[t.valLetter] = valAxis.c2l(density[i].t, true);
99100
}
100101
pathNeg = makePath(pts);
101102
}
25 KB
Loading
+94
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
{
2+
"data": [
3+
{
4+
"y": [
5+
1.0,
6+
1.1,
7+
1.0,
8+
0.9,
9+
1.2,
10+
2.0,
11+
1.5,
12+
2.3,
13+
1.7,
14+
2.2,
15+
1.0,
16+
1.1,
17+
1.2,
18+
0.9,
19+
1.1
20+
],
21+
"x": [
22+
1,
23+
1,
24+
1,
25+
1,
26+
1,
27+
10,
28+
10,
29+
10,
30+
10,
31+
10,
32+
100,
33+
100,
34+
100,
35+
100,
36+
100
37+
],
38+
"type": "violin",
39+
"box": {
40+
"visible": true
41+
},
42+
"meanline": {
43+
"visible": true
44+
},
45+
"side": "negative"
46+
},
47+
{
48+
"y": [
49+
2.2,
50+
2.3,
51+
2.0,
52+
2.5,
53+
2.1,
54+
0.1,
55+
0.5,
56+
0.8,
57+
0.3,
58+
0.3,
59+
2.4,
60+
2.0,
61+
1.5,
62+
1.6,
63+
1.9
64+
],
65+
"x": [
66+
1,
67+
1,
68+
1,
69+
1,
70+
1,
71+
10,
72+
10,
73+
10,
74+
10,
75+
10,
76+
100,
77+
100,
78+
100,
79+
100,
80+
100
81+
],
82+
"type": "violin",
83+
"meanline": {
84+
"visible": true
85+
},
86+
"side": "positive"
87+
}
88+
],
89+
"layout": {
90+
"xaxis": {
91+
"type": "log"
92+
}
93+
}
94+
}

0 commit comments

Comments
 (0)