Skip to content

Commit 31955e7

Browse files
authored
Merge pull request #5220 from plotly/archmoj-patch-1
Update pull-request template
2 parents 7f6650b + b3bcf23 commit 31955e7

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+2-5
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,17 @@ Thanks for your interest in plotly.js!
22

33
### Translations:
44

5-
- Make a PR directly to the main repository
65
- Please @ mention a few other speakers of this language who can help review your translations.
76
- If you've omitted any keys from [dist/translation_keys.txt](https://github.com/plotly/plotly.js/blob/master/dist/translation-keys.txt) - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
87
- You should only update files in `lib/locales/`, not those in `dist/`
98

109
### Features, Bug fixes, and others:
1110

12-
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
13-
14-
Before opening a pull request, developer should:
11+
Before opening a pull request, developer should:
1512

1613
- `git rebase` their local branch off the latest `master`,
1714
- make sure to **not** `git add` the `dist/` folder (the `dist/` is updated only on version bumps),
18-
- make sure to commit changes to the `package-lock.json` file (if any),
15+
- make sure to commit changes to the `package-lock.json` file (if any new dependency required),
1916
- write an overview of what the PR attempts to do,
2017
- select the _Allow edits from maintainers_ option (see this [article](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for more details).
2118

0 commit comments

Comments
 (0)