update polar for Plotly.react compatibility

Author: alexcjohnson

src/plots/polar/layout_defaults.js

@@ -87,6 +87,7 @@ function handleDefaults(contIn, contOut, coerce, opts) {
         switch(axName) {
             case 'radialaxis':
                 var autoRange = coerceAxis('autorange', !axOut.isValidRange(axIn.range));
+                axIn.autorange = autoRange;
                 if(autoRange) coerceAxis('rangemode');
                 if(autoRange === 'reversed') axOut._m = -1;
 

src/traces/scatterpolar/calc.js

@@ -26,7 +26,7 @@ module.exports = function calc(gd, trace) {
     var angularAxis = fullLayout[subplotId].angularaxis;
     var rArray = radialAxis.makeCalcdata(trace, 'r');
     var thetaArray = angularAxis.makeCalcdata(trace, 'theta');
-    var len = rArray.length;
+    var len = trace._length;
     var cd = new Array(len);
 
     function c2rad(v) {
@@ -53,6 +53,7 @@ module.exports = function calc(gd, trace) {
     if(angularAxis.type !== 'linear') {
         angularAxis.autorange = true;
         Axes.expand(angularAxis, thetaArray);
+        delete angularAxis.autorange;
     }
 
     calcColorscale(trace);

src/traces/scatterpolar/defaults.js

@@ -34,8 +34,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         return;
     }
 
-    if(len < r.length) traceOut.r = r.slice(0, len);
-    if(len < theta.length) traceOut.theta = theta.slice(0, len);
+    traceOut._length = len;
 
     coerce('thetaunit');
     coerce('mode', len < PTS_LINESONLY ? 'lines+markers' : 'lines');

src/traces/scatterpolargl/defaults.js

@@ -32,8 +32,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         return;
     }
 
-    if(len < r.length) traceOut.r = r.slice(0, len);
-    if(len < theta.length) traceOut.theta = theta.slice(0, len);
+    traceOut._length = len;
 
     coerce('thetaunit');
     coerce('mode', len < PTS_LINESONLY ? 'lines+markers' : 'lines');

src/traces/scatterpolargl/index.js

@@ -26,6 +26,9 @@ function calc(container, trace) {
     var thetaArray = angularAxis.makeCalcdata(trace, 'theta');
     var stash = {};
 
+    if(trace._length < rArray.length) rArray = rArray.slice(0, trace._length);
+    if(trace._length < thetaArray.length) thetaArray = thetaArray.slice(0, trace._length);
+
     calcColorscales(trace);
 
     stash.r = rArray;
@@ -36,6 +39,7 @@ function calc(container, trace) {
     if(angularAxis.type !== 'linear') {
         angularAxis.autorange = true;
         Axes.expand(angularAxis, thetaArray);
+        delete angularAxis.autorange;
     }
 
     return [{x: false, y: false, t: stash, trace: trace}];

test/jasmine/tests/scatterpolar_test.js

@@ -18,24 +18,28 @@ describe('Test scatterpolar trace defaults:', function() {
         ScatterPolar.supplyDefaults(traceIn, traceOut, '#444', layout || {});
     }
 
-    it('should truncate *r* when longer than *theta*', function() {
+    it('should not truncate *r* when longer than *theta*', function() {
+        // this is handled at the calc step now via _length.
         _supply({
             r: [1, 2, 3, 4, 5],
             theta: [1, 2, 3]
         });
 
-        expect(traceOut.r).toEqual([1, 2, 3]);
+        expect(traceOut.r).toEqual([1, 2, 3, 4, 5]);
         expect(traceOut.theta).toEqual([1, 2, 3]);
+        expect(traceOut._length).toBe(3);
     });
 
-    it('should truncate *theta* when longer than *r*', function() {
+    it('should not truncate *theta* when longer than *r*', function() {
+        // this is handled at the calc step now via _length.
         _supply({
             r: [1, 2, 3],
             theta: [1, 2, 3, 4, 5]
         });
 
         expect(traceOut.r).toEqual([1, 2, 3]);
-        expect(traceOut.theta).toEqual([1, 2, 3]);
+        expect(traceOut.theta).toEqual([1, 2, 3, 4, 5]);
+        expect(traceOut._length).toBe(3);
     });
 });