Skip to content

Commit 2ef3fce

Browse files
committed
Resolve TODO in cartesian/select.js regarding binned traces [1852]
- Replace TODO comment with a hint.
1 parent e460e46 commit 2ef3fce

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/plots/cartesian/select.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -474,10 +474,10 @@ function extractClickedPtInfo(hoverData, searchTraces) {
474474
break;
475475
}
476476

477-
// TODO hoverDatum not having a pointNumber but a binNumber seems to be an oddity of histogram only
478-
// Not deleting .pointNumber in histogram/event_data.js would simplify code here and in addition
479-
// would not break the hover event structure
480-
// documented at https://plot.ly/javascript/hover-events/
477+
// Hint: in some traces like histogram, one graphical element
478+
// doesn't correspond to one particular data point, but to
479+
// bins of data points. Thus, hoverDatum can have a binNumber
480+
// property instead of pointNumber.
481481
if(hoverDatum.pointNumber !== undefined) {
482482
pointNumber = hoverDatum.pointNumber;
483483
} else if(hoverDatum.binNumber !== undefined) {

0 commit comments

Comments
 (0)