Skip to content

Commit 28d94da

Browse files
committed
only need to check lonlat[0] === BADNUM
- to determine if calcdata item should be skipped
1 parent 2a91da6 commit 28d94da

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

src/lib/geojson_utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ exports.calcTraceToLineCoords = function(calcTrace) {
3333
var calcPt = calcTrace[i];
3434
var lonlat = calcPt.lonlat;
3535

36-
if(lonlat[0] !== BADNUM && lonlat[1] !== BADNUM) {
36+
if(lonlat[0] !== BADNUM) {
3737
lineString.push(lonlat);
3838
} else if(!connectgaps && lineString.length > 0) {
3939
coords.push(lineString);

src/traces/scattergeo/hover.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = function hoverPoints(pointData) {
3131
function distFn(d) {
3232
var lonlat = d.lonlat;
3333

34-
if(lonlat[0] === BADNUM || lonlat[1] === BADNUM) return Infinity;
34+
if(lonlat[0] === BADNUM) return Infinity;
3535

3636
if(geo.isLonLatOverEdges(lonlat)) return Infinity;
3737

src/traces/scattergeo/plot.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ module.exports = function plot(geo, calcData) {
2727
function keyFunc(d) { return d[0].trace.uid; }
2828

2929
function removeBADNUM(d, node) {
30-
var lonlat = d.lonlat;
31-
if(lonlat[0] === BADNUM || lonlat[1] === BADNUM) {
30+
if(d.lonlat[0] === BADNUM) {
3231
d3.select(node).remove();
3332
}
3433
}

0 commit comments

Comments
 (0)