Skip to content

Commit 219b48e

Browse files
committed
run mathjax mocks through orca
1 parent 1a4721d commit 219b48e

9 files changed

+26
-0
lines changed

tasks/noci_test.sh

+12
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,21 @@ test_jasmine () {
2626
# since the update to [email protected], we must use orca
2727
# as mapbox-gl versions >0.22.1 aren't supported on [email protected] used in the
2828
# 'old' image server
29+
#
30+
# due to mathjax upgrade to v2.7.5, we are unable to test mathjax mocks in the
31+
# 'old' image server and we use orca
32+
#
2933
test_image () {
3034
$root/../orca/bin/orca.js graph \
3135
$root/test/image/mocks/mapbox_* \
36+
$root/test/image/mocks/mathjax.json \
37+
$root/test/image/mocks/ternary-mathjax.json \
38+
$root/test/image/mocks/table_plain_birds.json \
39+
$root/test/image/mocks/table_wrapped_birds.json \
40+
$root/test/image/mocks/parcats_grid_subplots.json \
41+
$root/test/image/mocks/legend_mathjax_title_and_items.json \
42+
$root/test/image/mocks/table_latex_multitrace_scatter.json \
43+
--mathjax $root/node_modules/mathjax/MathJax.js \
3244
--plotly $root/build/plotly.js \
3345
--mapbox-access-token "pk.eyJ1IjoicGxvdGx5LWpzLXRlc3RzIiwiYSI6ImNrNG9meTJmOTAxa3UzZm10dWdteDQ2eWMifQ.2REjOFyIrleMqwS8H8y1-A" \
3446
--output-dir $root/test/image/baselines/ \
Loading

test/image/baselines/mathjax.png

-1.77 KB
Loading
2.13 KB
Loading
Loading
-84 Bytes
Loading
-117 Bytes
Loading
-2.12 KB
Loading

test/image/compare_pixels_test.js

+14
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,20 @@ function unique(value, index, self) {
8080
}
8181
allMockList = allMockList.filter(unique);
8282

83+
// Skip MathJax mocks that are tested using orca in noci_test
84+
var MATHJAX_LIST = [
85+
'mathjax',
86+
'ternary-mathjax',
87+
'table_plain_birds',
88+
'table_wrapped_birds',
89+
'parcats_grid_subplots',
90+
'legend_mathjax_title_and_items',
91+
'table_latex_multitrace_scatter'
92+
];
93+
allMockList = allMockList.filter(function(e) {
94+
return MATHJAX_LIST.indexOf(e) === -1;
95+
});
96+
8397
// filter out untestable mocks if no pattern is specified (ie. we're testing all mocks)
8498
// or if flag '--filter' is provided
8599
console.log('');

0 commit comments

Comments
 (0)