Skip to content

Commit 1e98161

Browse files
committed
tasks: use regex instead of loop over alphabet in patch minified step
1 parent f958b4f commit 1e98161

File tree

1 file changed

+3
-19
lines changed

1 file changed

+3
-19
lines changed

tasks/util/patch_minified.js

+3-19
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
var ALPHABET = 'abcdefghijklmnopqrstuvwxyz'.split('');
2-
var FRONT = 'require("+';
3-
var BACK = '+");';
1+
var PATTERN = /require\("\+(\w)\((\w)\)\+"\)/;
2+
var NEW_SUBSTR = 'require("+ $1($2) +")';
43

54
/* Uber hacky in-house fix to
65
*
@@ -19,20 +18,5 @@ var BACK = '+");';
1918
*
2019
*/
2120
module.exports = function patchMinified(minifiedCode) {
22-
for(var i = 0; i < ALPHABET.length; i++) {
23-
var li = ALPHABET[i];
24-
25-
for(var j = 0; j < ALPHABET.length; j++) {
26-
var lj = ALPHABET[j];
27-
28-
var MIDDLE = li + '(' + lj + ')';
29-
30-
var strOld = FRONT + MIDDLE + BACK,
31-
strNew = FRONT + ' ' + MIDDLE + ' ' + BACK;
32-
33-
minifiedCode = minifiedCode.replace(strOld, strNew);
34-
}
35-
}
36-
37-
return minifiedCode;
21+
return minifiedCode.replace(PATTERN, NEW_SUBSTR);
3822
};

0 commit comments

Comments
 (0)