Skip to content

Commit 1e86eb2

Browse files
committed
update scatter(ternary) supplyDefaults test for hoveron flaglist
1 parent aec4c95 commit 1e86eb2

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

test/jasmine/tests/scatter_test.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,12 @@ describe('Test scatter', function() {
6868
fill: 'tonext'
6969
};
7070

71-
// even with fill tonext, as long as there are markers or text
72-
// you get points
71+
// fills and markers, you get both hover types
7372
// you need visible: true here, as that normally gets set
7473
// outside of the module supplyDefaults
7574
traceOut = {visible: true};
7675
supplyDefaults(traceIn, traceOut, defaultColor, layout);
77-
expect(traceOut.hoveron).toBe('points');
76+
expect(traceOut.hoveron).toBe('points+fills');
7877

7978
// but with only lines (or just fill) and fill tonext or toself
8079
// you get fills

test/jasmine/tests/scatterternary_test.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,12 @@ describe('scatterternary defaults', function() {
168168
fill: 'tonext'
169169
};
170170

171-
// even with fill tonext, as long as there are markers or text
172-
// you get points
171+
// fills and markers, you get both hover types
173172
// you need visible: true here, as that normally gets set
174173
// outside of the module supplyDefaults
175174
traceOut = {visible: true};
176175
supplyDefaults(traceIn, traceOut, defaultColor, layout);
177-
expect(traceOut.hoveron).toBe('points');
176+
expect(traceOut.hoveron).toBe('points+fills');
178177

179178
// but with only lines (or just fill) and fill tonext or toself
180179
// you get fills

0 commit comments

Comments
 (0)