Skip to content

Commit 1c2e71e

Browse files
committed
add a few usefull TODOs
1 parent f17367f commit 1c2e71e

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

src/components/fx/hover.js

+2
Original file line numberDiff line numberDiff line change
@@ -447,10 +447,12 @@ function _hover(gd, evt, subplot) {
447447
pointNumber: pt.index
448448
};
449449

450+
// could maybe :hocho: _module.eventData
450451
if(pt.trace._module.eventData) out = pt.trace._module.eventData(out, pt);
451452
else {
452453
out.x = pt.xVal;
453454
out.y = pt.yVal;
455+
454456
out.xaxis = pt.xa;
455457
out.yaxis = pt.ya;
456458

src/plots/plots.js

+2
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,9 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
676676
Lib.pushUnique(modules, _module);
677677
Lib.pushUnique(basePlotModules, fullTrace._module.basePlotModule);
678678

679+
// TODO remove findArrayAttributes calls downstream
679680
fullTrace._arrayAttrs = PlotSchema.findArrayAttributes(fullTrace);
681+
680682
cnt++;
681683
}
682684

src/traces/scatter/select.js

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ module.exports = function selectPoints(searchInfo, polygon) {
4747
pointNumber: i,
4848
x: di.x,
4949
y: di.y,
50+
// TODO generalize with hover/click data handler
5051
id: di.id
5152
});
5253
di.dim = 0;

0 commit comments

Comments
 (0)